diff mbox

[dpdk-dev] i40e: fix the issue dcb cannot be configured when FW version is 5.x

Message ID 188971FCDA171749BED5DA74ABF3E6F0021D903C@shsmsx102.ccr.corp.intel.com (mailing list archive)
State Not Applicable, archived
Headers

Commit Message

Pei, Yulong Nov. 19, 2015, 6:16 a.m. UTC 
  Tested-by: Yulong Pei <Yulong.pei@intel.com>

-----Original Message-----
From: Wu, Jingjing 
Sent: Monday, November 16, 2015 4:57 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Pei, Yulong <yulong.pei@intel.com>
Subject: [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x

When NVM version is updated to 5.x, DCB can not be configured. This issue is because of the FW version validation is not correct.
This patch fixed this issue.

Fixes: c8b9a3e3fe1b (i40e: support DCB mode)

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
2.4.0

Comments

Thomas Monjalon Nov. 23, 2015, 10:20 p.m. UTC | #1 
> When NVM version is updated to 5.x, DCB can not be configured. This issue is because of the FW version validation is not correct.
> This patch fixed this issue.
> 
> Fixes: c8b9a3e3fe1b (i40e: support DCB mode)
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

Tested-by: Yulong Pei <yulong.pei@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 2c51a0b..9003488 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -8316,7 +8316,8 @@  i40e_dcb_hw_configure(struct i40e_pf *pf,
 	uint32_t val;
 
 	/* Use the FW API if FW > v4.4*/
-	if (!((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver >= 4))) {
+	if (!(((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver >= 4)) ||
+	      (hw->aq.fw_maj_ver >= 5))) {
 		PMD_INIT_LOG(ERR, "FW < v4.4, can not use FW LLDP API"
 				  " to configure DCB");
 		return I40E_ERR_FIRMWARE_API_VERSION;