| Message ID | 1447880321-16187-1-git-send-email-3chas3@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id CA1848D85; Wed, 18 Nov 2015 21:58:49 +0100 (CET) Received: from mail-qg0-f42.google.com (mail-qg0-f42.google.com [209.85.192.42]) by dpdk.org (Postfix) with ESMTP id 9490E5AA0 for <dev@dpdk.org>; Wed, 18 Nov 2015 21:58:48 +0100 (CET) Received: by qgad10 with SMTP id d10so38096586qga.3 for <dev@dpdk.org>; Wed, 18 Nov 2015 12:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=cFP9OD2NT356nPWtoqut61MqpdWDGsteHKDYPvKE2F4=; b=gEbPEBt/fYR+/BuRJAItNiOQ6L0/As4wMDABNa6XVRKmLCuBWVgL79PPt3hogQRj3B Iq/hFQcrAUs841i1oTX1xC6+p1N9vUfzKUS9qCis/0SVZty9wNxZWzuXofusvbG9dhhZ 64wdwohLmZPK2EEo+KTFafKGOEX/+8JtN84zNVr6LnKa8RHOqGFBheqct/xlaL0MEmiD QFFZmJZAPph3q/gkK3+illf+yq9L0DTPEmYmlh7m/IhO4wPm6slpl5/XsqV/XjQ1vctv avRsQgLyIr5g4wPRW2nx3+CqlRasClbVNACajVXTnxfzMNYnoG3iP1picB23XWSTbvnk 3zWQ== X-Received: by 10.140.162.214 with SMTP id i205mr3949205qhi.32.1447880328040; Wed, 18 Nov 2015 12:58:48 -0800 (PST) Received: from foobar.home (pool-71-163-182-126.washdc.fios.verizon.net. [71.163.182.126]) by smtp.gmail.com with ESMTPSA id 74sm1432318qha.41.2015.11.18.12.58.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2015 12:58:47 -0800 (PST) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Date: Wed, 18 Nov 2015 15:58:41 -0500 Message-Id: <1447880321-16187-1-git-send-email-3chas3@gmail.com> X-Mailer: git-send-email 2.1.0 Subject: [dpdk-dev] [PATCH] bnx2x: set Ethernet address type during transmit for VF's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Chas Williams
Nov. 18, 2015, 8:58 p.m. UTC
The original was always setting unicast. While here, clean up some
other references that also point into the Ethernet header.
Signed-off-by: Chas Williams <3chas3@gmail.com>
---
drivers/net/bnx2x/bnx2x.c | 23 +++++++++++++++--------
drivers/net/bnx2x/ecore_hsi.h | 5 +++--
2 files changed, 18 insertions(+), 10 deletions(-)
Comments
2015-11-18 15:58, Chas Williams: > The original was always setting unicast. While here, clean up some > other references that also point into the Ethernet header. > > Signed-off-by: Chas Williams <3chas3@gmail.com> Applied, thanks
2015-12-06 23:20, Thomas Monjalon: > 2015-11-18 15:58, Chas Williams: > > The original was always setting unicast. While here, clean up some > > other references that also point into the Ethernet header. > > > > Signed-off-by: Chas Williams <3chas3@gmail.com> > > Applied, thanks No sorry, not applied, it needs review.
> >The original was always setting unicast. While here, clean up some >other references that also point into the Ethernet header. > >Signed-off-by: Chas Williams <3chas3@gmail.com> >--- > drivers/net/bnx2x/bnx2x.c | 23 +++++++++++++++-------- > drivers/net/bnx2x/ecore_hsi.h | 5 +++-- > 2 files changed, 18 insertions(+), 10 deletions(-) > >diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c >index 76444eb..294711f 100644 >--- a/drivers/net/bnx2x/bnx2x.c >+++ b/drivers/net/bnx2x/bnx2x.c >@@ -2177,25 +2177,32 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, >struct rte_mbuf **m_head, int m_p > bd_prod = NEXT_TX_BD(bd_prod); > if (IS_VF(sc)) { > struct eth_tx_parse_bd_e2 *tx_parse_bd; >- uint8_t *data = rte_pktmbuf_mtod(m0, uint8_t *); >+ const struct ether_hdr *eh = rte_pktmbuf_mtod(m0, struct ether_hdr *); >+ uint8_t mac_type = UNICAST_ADDRESS; > > tx_parse_bd = > &txq->tx_ring[TX_BD(bd_prod, txq)].parse_bd_e2; >+ if (is_multicast_ether_addr(&eh->d_addr)) { Minor comment. unlikely() may be used here to keep it consistent with base driver. >+ if (is_broadcast_ether_addr(&eh->d_addr)) >+ mac_type = BROADCAST_ADDRESS; >+ else >+ mac_type = MULTICAST_ADDRESS; >+ } > tx_parse_bd->parsing_data = >- (1 << ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE_SHIFT); >+ (mac_type << ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE_SHIFT); > > rte_memcpy(&tx_parse_bd->data.mac_addr.dst_hi, >- &data[0], 2); >+ &eh->d_addr.addr_bytes[0], 2); > rte_memcpy(&tx_parse_bd->data.mac_addr.dst_mid, >- &data[2], 2); >+ &eh->d_addr.addr_bytes[2], 2); > rte_memcpy(&tx_parse_bd->data.mac_addr.dst_lo, >- &data[4], 2); >+ &eh->d_addr.addr_bytes[4], 2); > rte_memcpy(&tx_parse_bd->data.mac_addr.src_hi, >- &data[6], 2); >+ &eh->s_addr.addr_bytes[0], 2); > rte_memcpy(&tx_parse_bd->data.mac_addr.src_mid, >- &data[8], 2); >+ &eh->s_addr.addr_bytes[2], 2); > rte_memcpy(&tx_parse_bd->data.mac_addr.src_lo, >- &data[10], 2); >+ &eh->s_addr.addr_bytes[4], 2); > > tx_parse_bd->data.mac_addr.dst_hi = > rte_cpu_to_be_16(tx_parse_bd->data.mac_addr.dst_hi); >diff --git a/drivers/net/bnx2x/ecore_hsi.h b/drivers/net/bnx2x/ecore_hsi.h >index a4ed9b5..6c11c5a 100644 >--- a/drivers/net/bnx2x/ecore_hsi.h >+++ b/drivers/net/bnx2x/ecore_hsi.h >@@ -4029,7 +4029,7 @@ struct double_regpair > > > /* >- * Ethernet address typesm used in ethernet tx BDs >+ * Ethernet address types used in ethernet tx BDs > */ > enum eth_addr_type > { >@@ -4037,7 +4037,8 @@ enum eth_addr_type > UNICAST_ADDRESS, > MULTICAST_ADDRESS, > BROADCAST_ADDRESS, >- MAX_ETH_ADDR_TYPE}; >+ MAX_ETH_ADDR_TYPE >+}; > > > /* >-- >2.1.0 > > Acked-by: Harish Patil <harish.patil@qlogic.com> Thanks, Harish ________________________________ This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
On Sun, 2015-12-06 at 23:34 +0000, Harish Patil wrote: > > > >The original was always setting unicast. While here, clean up some > >other references that also point into the Ethernet header. > > > >Signed-off-by: Chas Williams <3chas3@gmail.com> > >--- > > drivers/net/bnx2x/bnx2x.c | 23 +++++++++++++++-------- > > drivers/net/bnx2x/ecore_hsi.h | 5 +++-- > > 2 files changed, 18 insertions(+), 10 deletions(-) > > > >diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c > >index 76444eb..294711f 100644 > >--- a/drivers/net/bnx2x/bnx2x.c > >+++ b/drivers/net/bnx2x/bnx2x.c > >@@ -2177,25 +2177,32 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, > >struct rte_mbuf **m_head, int m_p > > bd_prod = NEXT_TX_BD(bd_prod); > > if (IS_VF(sc)) { > > struct eth_tx_parse_bd_e2 *tx_parse_bd; > >- uint8_t *data = rte_pktmbuf_mtod(m0, uint8_t *); > >+ const struct ether_hdr *eh = rte_pktmbuf_mtod(m0, struct ether_hdr *); > >+ uint8_t mac_type = UNICAST_ADDRESS; > > > > tx_parse_bd = > > &txq->tx_ring[TX_BD(bd_prod, txq)].parse_bd_e2; > >+ if (is_multicast_ether_addr(&eh->d_addr)) { > > Minor comment. unlikely() may be used here to keep it consistent with base > driver. It wasn't clear to me that this code path is all that unlikely(). > >+ if (is_broadcast_ether_addr(&eh->d_addr)) > >+ mac_type = BROADCAST_ADDRESS; > >+ else > >+ mac_type = MULTICAST_ADDRESS; > >+ }
> >On Sun, 2015-12-06 at 23:34 +0000, Harish Patil wrote: >> > >> >The original was always setting unicast. While here, clean up some >> >other references that also point into the Ethernet header. >> > >> >Signed-off-by: Chas Williams <3chas3@gmail.com> >> >--- >> > drivers/net/bnx2x/bnx2x.c | 23 +++++++++++++++-------- >> > drivers/net/bnx2x/ecore_hsi.h | 5 +++-- >> > 2 files changed, 18 insertions(+), 10 deletions(-) >> > >> >diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c >> >index 76444eb..294711f 100644 >> >--- a/drivers/net/bnx2x/bnx2x.c >> >+++ b/drivers/net/bnx2x/bnx2x.c >> >@@ -2177,25 +2177,32 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, >> >struct rte_mbuf **m_head, int m_p >> > bd_prod = NEXT_TX_BD(bd_prod); >> > if (IS_VF(sc)) { >> > struct eth_tx_parse_bd_e2 *tx_parse_bd; >> >- uint8_t *data = rte_pktmbuf_mtod(m0, uint8_t *); >> >+ const struct ether_hdr *eh = >>rte_pktmbuf_mtod(m0, struct ether_hdr *); >> >+ uint8_t mac_type = UNICAST_ADDRESS; >> > >> > tx_parse_bd = >> > &txq->tx_ring[TX_BD(bd_prod, >>txq)].parse_bd_e2; >> >+ if (is_multicast_ether_addr(&eh->d_addr)) { >> >> Minor comment. unlikely() may be used here to keep it consistent with >>base >> driver. > >It wasn't clear to me that this code path is all that unlikely(). Its an optional comment, unlikely() is because fast path traffic is mostly unicast. BTW, have you tested the patches? Another question, not related to your change though. I guess this block of code does not have to been under the IS_VF() check. > >> >+ if >>(is_broadcast_ether_addr(&eh->d_addr)) >> >+ mac_type = BROADCAST_ADDRESS; >> >+ else >> >+ mac_type = MULTICAST_ADDRESS; >> >+ } > > > ________________________________ This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
On Mon, 2015-12-07 at 17:29 +0000, Harish Patil wrote: > > > >On Sun, 2015-12-06 at 23:34 +0000, Harish Patil wrote: > >> > > >> >The original was always setting unicast. While here, clean up some > >> >other references that also point into the Ethernet header. > >> > > >> >Signed-off-by: Chas Williams <3chas3@gmail.com> > >> >--- > >> > drivers/net/bnx2x/bnx2x.c | 23 +++++++++++++++-------- > >> > drivers/net/bnx2x/ecore_hsi.h | 5 +++-- > >> > 2 files changed, 18 insertions(+), 10 deletions(-) > >> > > >> >diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c > >> >index 76444eb..294711f 100644 > >> >--- a/drivers/net/bnx2x/bnx2x.c > >> >+++ b/drivers/net/bnx2x/bnx2x.c > >> >@@ -2177,25 +2177,32 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, > >> >struct rte_mbuf **m_head, int m_p > >> > bd_prod = NEXT_TX_BD(bd_prod); > >> > if (IS_VF(sc)) { > >> > struct eth_tx_parse_bd_e2 *tx_parse_bd; > >> >- uint8_t *data = rte_pktmbuf_mtod(m0, uint8_t *); > >> >+ const struct ether_hdr *eh = > >>rte_pktmbuf_mtod(m0, struct ether_hdr *); > >> >+ uint8_t mac_type = UNICAST_ADDRESS; > >> > > >> > tx_parse_bd = > >> > &txq->tx_ring[TX_BD(bd_prod, > >>txq)].parse_bd_e2; > >> >+ if (is_multicast_ether_addr(&eh->d_addr)) { > >> > >> Minor comment. unlikely() may be used here to keep it consistent with > >>base > >> driver. > > > >It wasn't clear to me that this code path is all that unlikely(). > > Its an optional comment, unlikely() is because fast path traffic is mostly > unicast. Multicast traffic isn't all that uncommon. I also don't see that we gain much from branch prediction here regardless. My understanding is that unlikely() should be used for really unlikely situations since the branch will not be optimized. > BTW, have you tested the patches? Another question, not related to your > change though. Yes. This patch is necessary (for VF anyway). Without it, you need to manually assign arp addresses. > I guess this block of code does not have to been under the IS_VF() check. I don't know. It is under IS_VF() in the linux driver and it looks like an attempt to "program" some internal switch on the card. I don't have a programmer's guide for this card so it's a complete guess. > >> >+ if > >>(is_broadcast_ether_addr(&eh->d_addr)) > >> >+ mac_type = BROADCAST_ADDRESS; > >> >+ else > >> >+ mac_type = MULTICAST_ADDRESS; > >> >+ }
On Tue, Dec 08, 2015 at 09:27:05AM -0500, Charles (Chas) Williams wrote: > On Mon, 2015-12-07 at 17:29 +0000, Harish Patil wrote: > > > > > >On Sun, 2015-12-06 at 23:34 +0000, Harish Patil wrote: > > >> > > > >> >The original was always setting unicast. While here, clean up some > > >> >other references that also point into the Ethernet header. > > >> > > > >> >Signed-off-by: Chas Williams <3chas3@gmail.com> > > >> >--- > > >> > drivers/net/bnx2x/bnx2x.c | 23 +++++++++++++++-------- > > >> > drivers/net/bnx2x/ecore_hsi.h | 5 +++-- > > >> > 2 files changed, 18 insertions(+), 10 deletions(-) > > >> > > > >> >diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c > > >> >index 76444eb..294711f 100644 > > >> >--- a/drivers/net/bnx2x/bnx2x.c > > >> >+++ b/drivers/net/bnx2x/bnx2x.c > > >> >@@ -2177,25 +2177,32 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, > > >> >struct rte_mbuf **m_head, int m_p > > >> > bd_prod = NEXT_TX_BD(bd_prod); > > >> > if (IS_VF(sc)) { > > >> > struct eth_tx_parse_bd_e2 *tx_parse_bd; > > >> >- uint8_t *data = rte_pktmbuf_mtod(m0, uint8_t *); > > >> >+ const struct ether_hdr *eh = > > >>rte_pktmbuf_mtod(m0, struct ether_hdr *); > > >> >+ uint8_t mac_type = UNICAST_ADDRESS; > > >> > > > >> > tx_parse_bd = > > >> > &txq->tx_ring[TX_BD(bd_prod, > > >>txq)].parse_bd_e2; > > >> >+ if (is_multicast_ether_addr(&eh->d_addr)) { > > >> > > >> Minor comment. unlikely() may be used here to keep it consistent with > > >>base > > >> driver. > > > > > >It wasn't clear to me that this code path is all that unlikely(). > > > > Its an optional comment, unlikely() is because fast path traffic is mostly > > unicast. > > Multicast traffic isn't all that uncommon. I also don't see that we gain > much from branch prediction here regardless. My understanding is that > unlikely() should be used for really unlikely situations since the branch > will not be optimized. +1 to this. Let the cpu branch predictor do the work at run-time picking the correct leg of the branch. likely()/unlikely() should only ever be used for things like fatal error conditions where it doesn't matter how optimized the unlikely branch part is. For normal code where there is no error, don't try and optimize it using likely()/unlikely() unless you can prove there is a definite performance improvement by doing so. /Bruce
>On Tue, Dec 08, 2015 at 09:27:05AM -0500, Charles (Chas) Williams wrote: >> On Mon, 2015-12-07 at 17:29 +0000, Harish Patil wrote: >> > > >> > >On Sun, 2015-12-06 at 23:34 +0000, Harish Patil wrote: >> > >> > >> > >> >The original was always setting unicast. While here, clean up >>some >> > >> >other references that also point into the Ethernet header. >> > >> > >> > >> >Signed-off-by: Chas Williams <3chas3@gmail.com> >> > >> >--- >> > >> > drivers/net/bnx2x/bnx2x.c | 23 +++++++++++++++-------- >> > >> > drivers/net/bnx2x/ecore_hsi.h | 5 +++-- >> > >> > 2 files changed, 18 insertions(+), 10 deletions(-) >> > >> > >> > >> >diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c >> > >> >index 76444eb..294711f 100644 >> > >> >--- a/drivers/net/bnx2x/bnx2x.c >> > >> >+++ b/drivers/net/bnx2x/bnx2x.c >> > >> >@@ -2177,25 +2177,32 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue >>*txq, >> > >> >struct rte_mbuf **m_head, int m_p >> > >> > bd_prod = NEXT_TX_BD(bd_prod); >> > >> > if (IS_VF(sc)) { >> > >> > struct eth_tx_parse_bd_e2 *tx_parse_bd; >> > >> >- uint8_t *data = rte_pktmbuf_mtod(m0, >>uint8_t *); >> > >> >+ const struct ether_hdr *eh = >> > >>rte_pktmbuf_mtod(m0, struct ether_hdr *); >> > >> >+ uint8_t mac_type = UNICAST_ADDRESS; >> > >> > >> > >> > tx_parse_bd = >> > >> > &txq->tx_ring[TX_BD(bd_prod, >> > >>txq)].parse_bd_e2; >> > >> >+ if (is_multicast_ether_addr(&eh->d_addr)) { >> > >> >> > >> Minor comment. unlikely() may be used here to keep it consistent >>with >> > >>base >> > >> driver. >> > > >> > >It wasn't clear to me that this code path is all that unlikely(). >> > >> > Its an optional comment, unlikely() is because fast path traffic is >>mostly >> > unicast. >> >> Multicast traffic isn't all that uncommon. I also don't see that we >>gain >> much from branch prediction here regardless. My understanding is that >> unlikely() should be used for really unlikely situations since the >>branch >> will not be optimized. > >+1 to this. > >Let the cpu branch predictor do the work at run-time picking the >correct leg of the branch. likely()/unlikely() should only ever be used >for >things like fatal error conditions where it doesn't matter how optimized >the >unlikely branch part is. For normal code where there is no error, don't >try and >optimize it using likely()/unlikely() unless you can prove there is a >definite >performance improvement by doing so. > >/Bruce > I agree too, lets leave it that way. As I said its optional, to be same as linux base driver which has: 3809 /* set flag according to packet type (UNICAST_ADDRESS is default)*/ 3810 if (unlikely(is_multicast_ether_addr(eth->h_dest))) { Thanks, Harish ________________________________ This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 76444eb..294711f 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -2177,25 +2177,32 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, struct rte_mbuf **m_head, int m_p bd_prod = NEXT_TX_BD(bd_prod); if (IS_VF(sc)) { struct eth_tx_parse_bd_e2 *tx_parse_bd; - uint8_t *data = rte_pktmbuf_mtod(m0, uint8_t *); + const struct ether_hdr *eh = rte_pktmbuf_mtod(m0, struct ether_hdr *); + uint8_t mac_type = UNICAST_ADDRESS; tx_parse_bd = &txq->tx_ring[TX_BD(bd_prod, txq)].parse_bd_e2; + if (is_multicast_ether_addr(&eh->d_addr)) { + if (is_broadcast_ether_addr(&eh->d_addr)) + mac_type = BROADCAST_ADDRESS; + else + mac_type = MULTICAST_ADDRESS; + } tx_parse_bd->parsing_data = - (1 << ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE_SHIFT); + (mac_type << ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE_SHIFT); rte_memcpy(&tx_parse_bd->data.mac_addr.dst_hi, - &data[0], 2); + &eh->d_addr.addr_bytes[0], 2); rte_memcpy(&tx_parse_bd->data.mac_addr.dst_mid, - &data[2], 2); + &eh->d_addr.addr_bytes[2], 2); rte_memcpy(&tx_parse_bd->data.mac_addr.dst_lo, - &data[4], 2); + &eh->d_addr.addr_bytes[4], 2); rte_memcpy(&tx_parse_bd->data.mac_addr.src_hi, - &data[6], 2); + &eh->s_addr.addr_bytes[0], 2); rte_memcpy(&tx_parse_bd->data.mac_addr.src_mid, - &data[8], 2); + &eh->s_addr.addr_bytes[2], 2); rte_memcpy(&tx_parse_bd->data.mac_addr.src_lo, - &data[10], 2); + &eh->s_addr.addr_bytes[4], 2); tx_parse_bd->data.mac_addr.dst_hi = rte_cpu_to_be_16(tx_parse_bd->data.mac_addr.dst_hi); diff --git a/drivers/net/bnx2x/ecore_hsi.h b/drivers/net/bnx2x/ecore_hsi.h index a4ed9b5..6c11c5a 100644 --- a/drivers/net/bnx2x/ecore_hsi.h +++ b/drivers/net/bnx2x/ecore_hsi.h @@ -4029,7 +4029,7 @@ struct double_regpair /* - * Ethernet address typesm used in ethernet tx BDs + * Ethernet address types used in ethernet tx BDs */ enum eth_addr_type { @@ -4037,7 +4037,8 @@ enum eth_addr_type UNICAST_ADDRESS, MULTICAST_ADDRESS, BROADCAST_ADDRESS, - MAX_ETH_ADDR_TYPE}; + MAX_ETH_ADDR_TYPE +}; /*