Message ID | 1447836609-23944-1-git-send-email-shaopeng.he@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9E800591E; Wed, 18 Nov 2015 09:50:18 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C6E533979 for <dev@dpdk.org>; Wed, 18 Nov 2015 09:50:16 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 18 Nov 2015 00:50:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,312,1444719600"; d="scan'208";a="822917872" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by orsmga001.jf.intel.com with ESMTP; 18 Nov 2015 00:50:15 -0800 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id tAI8oD2t016956; Wed, 18 Nov 2015 16:50:13 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id tAI8oAoN023982; Wed, 18 Nov 2015 16:50:12 +0800 Received: (from heshaope@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id tAI8oAD2023978; Wed, 18 Nov 2015 16:50:10 +0800 From: Shaopeng He <shaopeng.he@intel.com> To: dev@dpdk.org Date: Wed, 18 Nov 2015 16:50:09 +0800 Message-Id: <1447836609-23944-1-git-send-email-shaopeng.he@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] fm10k: fix wrong VLAN value in RX mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
He, Shaopeng
Nov. 18, 2015, 8:50 a.m. UTC
VLAN value should be copied from RX descriptor to mbuf,
this patch fixes this issue.
Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
---
drivers/net/fm10k/fm10k_rxtx.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi, Worth to adding comments that vlan_tci is only valid in case RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE is turned on and Flag PKT_RX_VLAN_PKT is set. Best Regards, Mark > -----Original Message----- > From: He, Shaopeng > Sent: Wednesday, November 18, 2015 4:50 PM > To: dev@dpdk.org > Cc: Chen, Jing D; Qiu, Michael; He, Shaopeng > Subject: [PATCH] fm10k: fix wrong VLAN value in RX mbuf > > VLAN value should be copied from RX descriptor to mbuf, > this patch fixes this issue. > > Signed-off-by: Shaopeng He <shaopeng.he@intel.com> > --- > drivers/net/fm10k/fm10k_rxtx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/fm10k/fm10k_rxtx.c > b/drivers/net/fm10k/fm10k_rxtx.c > index 1bac28d..eeb635e 100644 > --- a/drivers/net/fm10k/fm10k_rxtx.c > +++ b/drivers/net/fm10k/fm10k_rxtx.c > @@ -146,6 +146,7 @@ fm10k_recv_pkts(void *rx_queue, struct rte_mbuf > **rx_pkts, > #endif > > mbuf->hash.rss = desc.d.rss; > + mbuf->vlan_tci = desc.w.vlan & > FM10K_RXD_VLAN_ID_MASK; > > rx_pkts[count] = mbuf; > if (++next_dd == q->nb_desc) { > @@ -292,6 +293,7 @@ fm10k_recv_scattered_pkts(void *rx_queue, struct > rte_mbuf **rx_pkts, > rx_desc_to_ol_flags(first_seg, &desc); > #endif > first_seg->hash.rss = desc.d.rss; > + first_seg->vlan_tci = desc.w.vlan & > FM10K_RXD_VLAN_ID_MASK; > > /* Prefetch data of first segment, if configured to do so. */ > rte_packet_prefetch((char *)first_seg->buf_addr + > -- > 1.9.3
On Wed, 18 Nov 2015 16:50:09 +0800 Shaopeng He <shaopeng.he@intel.com> wrote: > VLAN value should be copied from RX descriptor to mbuf, > this patch fixes this issue. > > Signed-off-by: Shaopeng He <shaopeng.he@intel.com> > --- > drivers/net/fm10k/fm10k_rxtx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c > index 1bac28d..eeb635e 100644 > --- a/drivers/net/fm10k/fm10k_rxtx.c > +++ b/drivers/net/fm10k/fm10k_rxtx.c > @@ -146,6 +146,7 @@ fm10k_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > #endif > > mbuf->hash.rss = desc.d.rss; > + mbuf->vlan_tci = desc.w.vlan & FM10K_RXD_VLAN_ID_MASK; > > rx_pkts[count] = mbuf; > if (++next_dd == q->nb_desc) { > @@ -292,6 +293,7 @@ fm10k_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > rx_desc_to_ol_flags(first_seg, &desc); > #endif > first_seg->hash.rss = desc.d.rss; > + first_seg->vlan_tci = desc.w.vlan & FM10K_RXD_VLAN_ID_MASK; > > /* Prefetch data of first segment, if configured to do so. */ > rte_packet_prefetch((char *)first_seg->buf_addr + Good catch, this bug means VLAN's would not work right now. But I think it isn't quite right. By masking the VLAN you are losing the received priority bits. Other drivers like ixgbe preserve the priority bits.
Hi, Mark > -----Original Message----- > From: Chen, Jing D > Sent: Thursday, November 19, 2015 3:05 PM > To: He, Shaopeng; dev@dpdk.org > Cc: Qiu, Michael > Subject: RE: [PATCH] fm10k: fix wrong VLAN value in RX mbuf > > Hi, > > Worth to adding comments that vlan_tci is only valid in case > RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE is turned on and Flag > PKT_RX_VLAN_PKT is set. Good suggestion. But, actually, we have a little different case in fm10k: fm10k has a switch core inside, which associates a VLAN ID for each packet. For those packets coming in without a VLAN, the port default VLAN ID will be used. So for fm10k, vlan_tci is always valid. For Flag PKT_RX_VLAN_PKT, currently it will be set when there is inner VLAN in the packet. This is not correct, I will fix it by setting PKT_RX_VLAN_PKT always on in next version. To verify this, different situations have been tested on current implementation: 1. Ixia sent VLAN 51 packet, DPDK received: vlan_tci=51, PKT_RX_VLAN_PKT=0 2. sent non-VLAN packet, ether port's default VLAN ID is 1 received: vlan_tci=1, PKT_RX_VLAN_PKT=0 3. sent double-VLAN packet (outer 51, inner 17), received: vlan_tci=51, PKT_RX_VLAN_PKT=1 Thanks, --Shaopeng > > Best Regards, > Mark > > > > -----Original Message----- > > From: He, Shaopeng > > Sent: Wednesday, November 18, 2015 4:50 PM > > To: dev@dpdk.org > > Cc: Chen, Jing D; Qiu, Michael; He, Shaopeng > > Subject: [PATCH] fm10k: fix wrong VLAN value in RX mbuf > > > > VLAN value should be copied from RX descriptor to mbuf, this patch > > fixes this issue. > > > > Signed-off-by: Shaopeng He <shaopeng.he@intel.com> > > --- > > drivers/net/fm10k/fm10k_rxtx.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/fm10k/fm10k_rxtx.c > > b/drivers/net/fm10k/fm10k_rxtx.c index 1bac28d..eeb635e 100644 > > --- a/drivers/net/fm10k/fm10k_rxtx.c > > +++ b/drivers/net/fm10k/fm10k_rxtx.c > > @@ -146,6 +146,7 @@ fm10k_recv_pkts(void *rx_queue, struct rte_mbuf > > **rx_pkts, #endif > > > > mbuf->hash.rss = desc.d.rss; > > + mbuf->vlan_tci = desc.w.vlan & > > FM10K_RXD_VLAN_ID_MASK; > > > > rx_pkts[count] = mbuf; > > if (++next_dd == q->nb_desc) { > > @@ -292,6 +293,7 @@ fm10k_recv_scattered_pkts(void *rx_queue, struct > > rte_mbuf **rx_pkts, > > rx_desc_to_ol_flags(first_seg, &desc); #endif > > first_seg->hash.rss = desc.d.rss; > > + first_seg->vlan_tci = desc.w.vlan & > > FM10K_RXD_VLAN_ID_MASK; > > > > /* Prefetch data of first segment, if configured to do so. */ > > rte_packet_prefetch((char *)first_seg->buf_addr + > > -- > > 1.9.3
Hi, Stephen > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, November 20, 2015 1:26 AM > To: He, Shaopeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fm10k: fix wrong VLAN value in RX mbuf > > On Wed, 18 Nov 2015 16:50:09 +0800 > Shaopeng He <shaopeng.he@intel.com> wrote: > > > VLAN value should be copied from RX descriptor to mbuf, this patch > > fixes this issue. > > > > Signed-off-by: Shaopeng He <shaopeng.he@intel.com> > > --- > > drivers/net/fm10k/fm10k_rxtx.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/fm10k/fm10k_rxtx.c > > b/drivers/net/fm10k/fm10k_rxtx.c index 1bac28d..eeb635e 100644 > > --- a/drivers/net/fm10k/fm10k_rxtx.c > > +++ b/drivers/net/fm10k/fm10k_rxtx.c > > @@ -146,6 +146,7 @@ fm10k_recv_pkts(void *rx_queue, struct rte_mbuf > > **rx_pkts, #endif > > > > mbuf->hash.rss = desc.d.rss; > > + mbuf->vlan_tci = desc.w.vlan & > FM10K_RXD_VLAN_ID_MASK; > > > > rx_pkts[count] = mbuf; > > if (++next_dd == q->nb_desc) { > > @@ -292,6 +293,7 @@ fm10k_recv_scattered_pkts(void *rx_queue, struct > rte_mbuf **rx_pkts, > > rx_desc_to_ol_flags(first_seg, &desc); #endif > > first_seg->hash.rss = desc.d.rss; > > + first_seg->vlan_tci = desc.w.vlan & > FM10K_RXD_VLAN_ID_MASK; > > > > /* Prefetch data of first segment, if configured to do so. */ > > rte_packet_prefetch((char *)first_seg->buf_addr + > > Good catch, this bug means VLAN's would not work right now. > But I think it isn't quite right. Actually, VLAN filter works well, only the vlan_tci in mbuf has wrong value. And because not much places use the vlan_tci, this bug was not found before. > > By masking the VLAN you are losing the received priority bits. > Other drivers like ixgbe preserve the priority bits. Yes, you are right, in next version, I will preserve the priority bits like others. Thanks, --Shaopeng
diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c index 1bac28d..eeb635e 100644 --- a/drivers/net/fm10k/fm10k_rxtx.c +++ b/drivers/net/fm10k/fm10k_rxtx.c @@ -146,6 +146,7 @@ fm10k_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, #endif mbuf->hash.rss = desc.d.rss; + mbuf->vlan_tci = desc.w.vlan & FM10K_RXD_VLAN_ID_MASK; rx_pkts[count] = mbuf; if (++next_dd == q->nb_desc) { @@ -292,6 +293,7 @@ fm10k_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, rx_desc_to_ol_flags(first_seg, &desc); #endif first_seg->hash.rss = desc.d.rss; + first_seg->vlan_tci = desc.w.vlan & FM10K_RXD_VLAN_ID_MASK; /* Prefetch data of first segment, if configured to do so. */ rte_packet_prefetch((char *)first_seg->buf_addr +