[dpdk-dev] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()
Commit Message
Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
lib/librte_ether/rte_ether_version.map | 1 +
1 file changed, 1 insertion(+)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, November 18, 2015 7:34 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
> rte_eth_dma_zone_reserve()
>
> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Out of curiosity, how did you identify this issue?
On 11/18/2015 01:48 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
>> Sent: Wednesday, November 18, 2015 7:34 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
>> rte_eth_dma_zone_reserve()
>>
>> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
>>
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
>
> Out of curiosity, how did you identify this issue?
These kind of issues are hard not to notice when using shared library
configuration once there's something actually using the symbol. In this
case, the four commits following 719dbebceb81 make the e1000, ixgbe, i40
and fm10k pmds unloadable respectively:
librte_pmd_ixgbe.so: undefined symbol: rte_eth_dma_zone_reserve
Driver autoloading does help unearthing these issues too since all the
pmd's get loaded regardless of the actual hardware present.
- Panu -
> > Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
> >
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
@@ -133,6 +133,7 @@ DPDK_2.2 {
rte_eth_copy_pci_info;
rte_eth_dev_get_dcb_info;
+ rte_eth_dma_zone_reserve;
rte_eth_rx_queue_info_get;
rte_eth_timesync_adjust_time;
rte_eth_timesync_read_time;