diff mbox

[dpdk-dev] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

Message ID 1447778782-8659-1-git-send-email-zhe.tao@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Zhe Tao Nov. 17, 2015, 4:46 p.m. UTC 
  Configure the vector PMD option as no for default as a work around for l3fwd.
After the l3fwd app can handle the undefined ptype or the i40e vPMD can return
the ptype, the option will be set as yes for default again.

Signed-off-by: Zhe Tao <zhe.tao@intel.com>
---
 config/common_bsdapp   | 2 +-
 config/common_linuxapp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Zhang, Helin Nov. 18, 2015, 5:30 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhe Tao
> Sent: Wednesday, November 18, 2015 12:46 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: configure the vector PMD option as no for
> default for l3fwd undefined ptype issue
> 
> Configure the vector PMD option as no for default as a work around for l3fwd.
> After the l3fwd app can handle the undefined ptype or the i40e vPMD can
> return the ptype, the option will be set as yes for default again.
> 
> Signed-off-by: Zhe Tao <zhe.tao@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
Thomas Monjalon Nov. 23, 2015, 11:11 a.m. UTC | #2 
> > Configure the vector PMD option as no for default as a work around for l3fwd.
> > After the l3fwd app can handle the undefined ptype or the i40e vPMD can
> > return the ptype, the option will be set as yes for default again.
> > 
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Few comments:
1/ The issue is not described.
2/ The release notes should be updated in the section "known issues".
3/ Changing the default config option won't prevent users from enable it.
If it is broken, it is better to fix or revert it.
diff mbox

Patch

diff --git a/config/common_bsdapp b/config/common_bsdapp
index 7df0763..a9b51ff 100644
--- a/config/common_bsdapp
+++ b/config/common_bsdapp
@@ -189,7 +189,7 @@  CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
-CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
+CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n
 CONFIG_RTE_LIBRTE_I40E_RX_OLFLAGS_ENABLE=y
 CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n
 CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=64
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 52173d5..56d6287 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -187,7 +187,7 @@  CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
-CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
+CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n
 CONFIG_RTE_LIBRTE_I40E_RX_OLFLAGS_ENABLE=y
 CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n
 CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=64