diff mbox

[dpdk-dev,v2] ring: fix minor memory free issue

Message ID 1446831639-9576-1-git-send-email-john.mcnamara@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

John McNamara Nov. 6, 2015, 5:40 p.m. UTC 
  Fix minor memory free issue in error clean-up.

Fixes: 651c505af862 ("ring: enhance device setup from rings")
Reported-by Coverity (CID 119258)

Signed-off-by: John McNamara <john.mcnamara@intel.com>
---

V2:
* Add fixline.

 drivers/net/ring/rte_eth_ring.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index cc60008..b91a643 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -363,9 +363,11 @@  rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
 	return data->port_id;
 
 error:
-	rte_free(data->rx_queues);
-	rte_free(data->tx_queues);
-	rte_free(data);
+	if (data) {
+		rte_free(data->rx_queues);
+		rte_free(data->tx_queues);
+		rte_free(data);
+	}
 	rte_free(internals);
 
 	return -1;