| Message ID | 1446789877-11656-1-git-send-email-xiaobo.chi@nokia.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E588A8D95; Fri, 6 Nov 2015 07:04:48 +0100 (CET) Received: from demumfd001.nsn-inter.net (demumfd001.nsn-inter.net [93.183.12.32]) by dpdk.org (Postfix) with ESMTP id 8A5AA5A6B for <dev@dpdk.org>; Fri, 6 Nov 2015 07:04:46 +0100 (CET) Received: from demuprx016.emea.nsn-intra.net ([10.150.129.55]) by demumfd001.nsn-inter.net (8.15.2/8.15.2) with ESMTPS id tA664jN8006584 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Nov 2015 06:04:46 GMT Received: from localhost ([10.140.176.165]) by demuprx016.emea.nsn-intra.net (8.12.11.20060308/8.12.11) with ESMTP id tA664cbu013556; Fri, 6 Nov 2015 07:04:42 +0100 From: Xiaobo Chi <xiaobo.chi@nokia.com> To: dev@dpdk.org Date: Fri, 6 Nov 2015 14:04:37 +0800 Message-Id: <1446789877-11656-1-git-send-email-xiaobo.chi@nokia.com> X-Mailer: git-send-email 1.9.4.msysgit.2 X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-size: 760 X-purgate-ID: 151667::1446789886-00000D72-7BD08AD2/0/0 Cc: Xiaobo Chi <xiaobo.chi@nokia.com>, changchun.ouyang@intel.com Subject: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
chixiaobo
Nov. 6, 2015, 6:04 a.m. UTC
eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading.
Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com>
---
lib/librte_vhost/eventfd_link/eventfd_link.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, Nov 06, 2015 at 02:04:37PM +0800, Xiaobo Chi wrote: > eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading. For such (fix) patch, I'd like to see what exact issue your patch fixes. And if it fixes an issue, you'd better title your patch with something like "vhost: fix ...", so that it's likely Thomas will put it into high priority. --yliu > > Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com> > --- > lib/librte_vhost/eventfd_link/eventfd_link.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c > index c54a938..4b05b5a 100644 > --- a/lib/librte_vhost/eventfd_link/eventfd_link.c > +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c > @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = { > > > static struct miscdevice eventfd_link_misc = { > + .minor = MISC_DYNAMIC_MINOR, > .name = "eventfd-link", > .fops = &eventfd_link_fops, > }; > -- > 1.9.4.msysgit.2
Hi, For miscdevices, the major device_no is same, so the minor device_no should be set to ditinguish different misc devices; if not set the minor, it may fail while insmod due to the default minor value, 0, has been used by other miscdevice. MISC_DYNAMIC_MINOR means to let Linux kernel dynamically assign one minor devide number while loading. You can refer to the kni_misc.c Brgs, Chi Xiaobo -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of EXT Yuanhan Liu Sent: Monday, November 09, 2015 12:23 PM To: Chi, Xiaobo (Nokia - CN/Hangzhou) Cc: dev@dpdk.org; changchun.ouyang@intel.com Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified On Fri, Nov 06, 2015 at 02:04:37PM +0800, Xiaobo Chi wrote: > eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading. For such (fix) patch, I'd like to see what exact issue your patch fixes. And if it fixes an issue, you'd better title your patch with something like "vhost: fix ...", so that it's likely Thomas will put it into high priority. --yliu > > Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com> > --- > lib/librte_vhost/eventfd_link/eventfd_link.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c > index c54a938..4b05b5a 100644 > --- a/lib/librte_vhost/eventfd_link/eventfd_link.c > +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c > @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = { > > > static struct miscdevice eventfd_link_misc = { > + .minor = MISC_DYNAMIC_MINOR, > .name = "eventfd-link", > .fops = &eventfd_link_fops, > }; > -- > 1.9.4.msysgit.2
Hi, And following is a test by me, we can see that if I firstly insert my kmod_test.ko, then insert eventfd_link.ko, error will happen with hint " Device or resource busy". This is because the default minor device number, 0, has been occupied by my kmod_test.ko . root@distro:~/test$ lsmod Module Size Used by kmod_test 927 0 vboxsf 35930 4 vboxguest 222130 1 vboxsf microcode 10315 0 autofs4 25051 0 root@distro:~/test$ modinfo kmod_test modinfo: ERROR: Module kmod_test not found. root@distro:~/test$ modinfo kmod_test.ko filename: /root/test/kmod_test.ko alias: devname:test description: my test author: Xiaobo Chi license: GPL v2 version: 0.0.1 srcversion: C2BDEBC81A17F8197C7C44A depends: vermagic: 3.18.9-pc64-distro.git-v1.7 SMP mod_unload root@distro:~/test$ dmesg -c root@distro:~/test$ ls eventfd_link.ko kmod_test.ko kmod_test.mod.o main Makefile Module.symvers kmod_test.c kmod_test.mod.c kmod_test.o main.c modules.order root@distro:~/test$ insmod ./eventfd_link.ko insmod: ERROR: could not insert module ./eventfd_link.ko: Device or resource busy root@distro:~/test$ dmesg -c brgs, Xiaobo Chi -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of EXT Chi, Xiaobo (Nokia - CN/Hangzhou) Sent: Monday, November 09, 2015 6:03 PM To: EXT Yuanhan Liu Cc: dev@dpdk.org; changchun.ouyang@intel.com Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified Hi, For miscdevices, the major device_no is same, so the minor device_no should be set to ditinguish different misc devices; if not set the minor, it may fail while insmod due to the default minor value, 0, has been used by other miscdevice. MISC_DYNAMIC_MINOR means to let Linux kernel dynamically assign one minor devide number while loading. You can refer to the kni_misc.c Brgs, Chi Xiaobo -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of EXT Yuanhan Liu Sent: Monday, November 09, 2015 12:23 PM To: Chi, Xiaobo (Nokia - CN/Hangzhou) Cc: dev@dpdk.org; changchun.ouyang@intel.com Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified On Fri, Nov 06, 2015 at 02:04:37PM +0800, Xiaobo Chi wrote: > eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading. For such (fix) patch, I'd like to see what exact issue your patch fixes. And if it fixes an issue, you'd better title your patch with something like "vhost: fix ...", so that it's likely Thomas will put it into high priority. --yliu > > Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com> > --- > lib/librte_vhost/eventfd_link/eventfd_link.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c > index c54a938..4b05b5a 100644 > --- a/lib/librte_vhost/eventfd_link/eventfd_link.c > +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c > @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = { > > > static struct miscdevice eventfd_link_misc = { > + .minor = MISC_DYNAMIC_MINOR, > .name = "eventfd-link", > .fops = &eventfd_link_fops, > }; > -- > 1.9.4.msysgit.2
On Mon, Nov 09, 2015 at 10:19:54AM +0000, Chi, Xiaobo (Nokia - CN/Hangzhou) wrote: > Hi, > > And following is a test by me, we can see that if I firstly insert my kmod_test.ko, then insert eventfd_link.ko, error will happen with hint " Device or resource busy". This is because the default minor device number, 0, has been occupied by my kmod_test.ko . Good to know and thanks for the explanation. It's well explained, and you should put them (including below example) to commit log. With the detailed issue explanation, and steps to reproduce, it just gives your patch more chance to get reviewed (and merged). And, don't forget to title your patch with "vhost: fix ..." preifx. FYI, there is another custom for a fix patch in DPDK community: adding an extra line like following to indicate the latest commit introduces such bug: Fixes: 62dbd2ffea9a ("ethdev: add more flow director modes") Which is generated with following git alias (check http://dpdk.org/dev for more information): [alias] fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' So, would you please send v2? --yliu > > root@distro:~/test$ lsmod > Module Size Used by > kmod_test 927 0 > vboxsf 35930 4 > vboxguest 222130 1 vboxsf > microcode 10315 0 > autofs4 25051 0 > root@distro:~/test$ modinfo kmod_test > modinfo: ERROR: Module kmod_test not found. > root@distro:~/test$ modinfo kmod_test.ko > filename: /root/test/kmod_test.ko > alias: devname:test > description: my test > author: Xiaobo Chi > license: GPL v2 > version: 0.0.1 > srcversion: C2BDEBC81A17F8197C7C44A > depends: > vermagic: 3.18.9-pc64-distro.git-v1.7 SMP mod_unload > root@distro:~/test$ dmesg -c > root@distro:~/test$ ls > eventfd_link.ko kmod_test.ko kmod_test.mod.o main Makefile Module.symvers > kmod_test.c kmod_test.mod.c kmod_test.o main.c modules.order > root@distro:~/test$ insmod ./eventfd_link.ko > insmod: ERROR: could not insert module ./eventfd_link.ko: Device or resource busy > root@distro:~/test$ dmesg -c > > brgs, > Xiaobo Chi > > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of EXT Chi, Xiaobo (Nokia - CN/Hangzhou) > Sent: Monday, November 09, 2015 6:03 PM > To: EXT Yuanhan Liu > Cc: dev@dpdk.org; changchun.ouyang@intel.com > Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified > > Hi, > For miscdevices, the major device_no is same, so the minor device_no should be set to ditinguish different misc devices; if not set the minor, it may fail while insmod due to the default minor value, 0, has been used by other miscdevice. MISC_DYNAMIC_MINOR means to let Linux kernel dynamically assign one minor devide number while loading. > You can refer to the kni_misc.c > > Brgs, > Chi Xiaobo > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of EXT Yuanhan Liu > Sent: Monday, November 09, 2015 12:23 PM > To: Chi, Xiaobo (Nokia - CN/Hangzhou) > Cc: dev@dpdk.org; changchun.ouyang@intel.com > Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified > > On Fri, Nov 06, 2015 at 02:04:37PM +0800, Xiaobo Chi wrote: > > eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading. > > For such (fix) patch, I'd like to see what exact issue your patch fixes. > > And if it fixes an issue, you'd better title your patch with something > like "vhost: fix ...", so that it's likely Thomas will put it into > high priority. > > --yliu > > > > > Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com> > > --- > > lib/librte_vhost/eventfd_link/eventfd_link.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c > > index c54a938..4b05b5a 100644 > > --- a/lib/librte_vhost/eventfd_link/eventfd_link.c > > +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c > > @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = { > > > > > > static struct miscdevice eventfd_link_misc = { > > + .minor = MISC_DYNAMIC_MINOR, > > .name = "eventfd-link", > > .fops = &eventfd_link_fops, > > }; > > -- > > 1.9.4.msysgit.2
Hi, Liu, thanks for your comments and guide. I will send a v2 soon. Brgs, Xiaobo Chi -----Original Message----- From: EXT Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] Sent: Monday, November 09, 2015 8:58 PM To: Chi, Xiaobo (Nokia - CN/Hangzhou) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified On Mon, Nov 09, 2015 at 10:19:54AM +0000, Chi, Xiaobo (Nokia - CN/Hangzhou) wrote: > Hi, > > And following is a test by me, we can see that if I firstly insert my kmod_test.ko, then insert eventfd_link.ko, error will happen with hint " Device or resource busy". This is because the default minor device number, 0, has been occupied by my kmod_test.ko . Good to know and thanks for the explanation. It's well explained, and you should put them (including below example) to commit log. With the detailed issue explanation, and steps to reproduce, it just gives your patch more chance to get reviewed (and merged). And, don't forget to title your patch with "vhost: fix ..." preifx. FYI, there is another custom for a fix patch in DPDK community: adding an extra line like following to indicate the latest commit introduces such bug: Fixes: 62dbd2ffea9a ("ethdev: add more flow director modes") Which is generated with following git alias (check http://dpdk.org/dev for more information): [alias] fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' So, would you please send v2? --yliu > > root@distro:~/test$ lsmod > Module Size Used by > kmod_test 927 0 > vboxsf 35930 4 > vboxguest 222130 1 vboxsf > microcode 10315 0 > autofs4 25051 0 > root@distro:~/test$ modinfo kmod_test > modinfo: ERROR: Module kmod_test not found. > root@distro:~/test$ modinfo kmod_test.ko > filename: /root/test/kmod_test.ko > alias: devname:test > description: my test > author: Xiaobo Chi > license: GPL v2 > version: 0.0.1 > srcversion: C2BDEBC81A17F8197C7C44A > depends: > vermagic: 3.18.9-pc64-distro.git-v1.7 SMP mod_unload > root@distro:~/test$ dmesg -c > root@distro:~/test$ ls > eventfd_link.ko kmod_test.ko kmod_test.mod.o main Makefile Module.symvers > kmod_test.c kmod_test.mod.c kmod_test.o main.c modules.order > root@distro:~/test$ insmod ./eventfd_link.ko > insmod: ERROR: could not insert module ./eventfd_link.ko: Device or resource busy > root@distro:~/test$ dmesg -c > > brgs, > Xiaobo Chi > > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of EXT Chi, Xiaobo (Nokia - CN/Hangzhou) > Sent: Monday, November 09, 2015 6:03 PM > To: EXT Yuanhan Liu > Cc: dev@dpdk.org; changchun.ouyang@intel.com > Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified > > Hi, > For miscdevices, the major device_no is same, so the minor device_no should be set to ditinguish different misc devices; if not set the minor, it may fail while insmod due to the default minor value, 0, has been used by other miscdevice. MISC_DYNAMIC_MINOR means to let Linux kernel dynamically assign one minor devide number while loading. > You can refer to the kni_misc.c > > Brgs, > Chi Xiaobo > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of EXT Yuanhan Liu > Sent: Monday, November 09, 2015 12:23 PM > To: Chi, Xiaobo (Nokia - CN/Hangzhou) > Cc: dev@dpdk.org; changchun.ouyang@intel.com > Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified > > On Fri, Nov 06, 2015 at 02:04:37PM +0800, Xiaobo Chi wrote: > > eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading. > > For such (fix) patch, I'd like to see what exact issue your patch fixes. > > And if it fixes an issue, you'd better title your patch with something > like "vhost: fix ...", so that it's likely Thomas will put it into > high priority. > > --yliu > > > > > Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com> > > --- > > lib/librte_vhost/eventfd_link/eventfd_link.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c > > index c54a938..4b05b5a 100644 > > --- a/lib/librte_vhost/eventfd_link/eventfd_link.c > > +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c > > @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = { > > > > > > static struct miscdevice eventfd_link_misc = { > > + .minor = MISC_DYNAMIC_MINOR, > > .name = "eventfd-link", > > .fops = &eventfd_link_fops, > > }; > > -- > > 1.9.4.msysgit.2
diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c index c54a938..4b05b5a 100644 --- a/lib/librte_vhost/eventfd_link/eventfd_link.c +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = { static struct miscdevice eventfd_link_misc = { + .minor = MISC_DYNAMIC_MINOR, .name = "eventfd-link", .fops = &eventfd_link_fops, };