diff mbox

[dpdk-dev] Add build switches for all DPDK applications. This makes it possible to skip building applications (and build only libraries or kernel drivers).

Message ID 1446215253-3188-1-git-send-email-francesco.montorsi@gmail.com (mailing list archive)
State Changes Requested, archived
Headers

Commit Message

Francesco Montorsi Oct. 30, 2015, 2:27 p.m. UTC 
  ---
 app/Makefile           |  8 ++++----
 config/common_linuxapp | 21 +++++++++++++++++++++
 2 files changed, 25 insertions(+), 4 deletions(-)

Comments

John McNamara Oct. 30, 2015, 4:39 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Francesco Montorsi
> Sent: Friday, October 30, 2015 2:28 PM
> To: dev@dpdk.org
> Cc: Francesco Montorsi
> Subject: [dpdk-dev] [PATCH] Add build switches for all DPDK applications.
> This makes it possible to skip building applications (and build only
> libraries or kernel drivers).

Hi,

Thanks for the patch.

The patch needs to signed and the title is too long (part of it should be in the body). See the following contributing guidelines:

    http://dpdk.org/dev/patchwork/patch/7935/

I don't know if people will want to add more compile time options. In general we are trying to remove them.

I do like the idea of being able to turn off building app/test which can a long time (even with -j).

Maybe it should only be built when you run "make test".

John.
--
diff mbox

Patch

diff --git a/app/Makefile b/app/Makefile
index 88c0bad..0b266b5 100644
--- a/app/Makefile
+++ b/app/Makefile
@@ -32,10 +32,10 @@ 
 include $(RTE_SDK)/mk/rte.vars.mk
 
 DIRS-$(CONFIG_RTE_APP_TEST) += test
-DIRS-$(CONFIG_RTE_LIBRTE_ACL) += test-acl
-DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += test-pipeline
+DIRS-$(CONFIG_RTE_APP_ACL_TEST) += test-acl
+DIRS-$(CONFIG_RTE_APP_PIPELINE_TEST) += test-pipeline
 DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
-DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_test
-DIRS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += proc_info
+DIRS-$(CONFIG_RTE_APP_CMDLINE_TEST) += cmdline_test
+DIRS-$(CONFIG_RTE_APP_PROC_INFO) += proc_info
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 0de43d5..b6703b1 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -466,3 +466,24 @@  CONFIG_RTE_APP_TEST=y
 CONFIG_RTE_TEST_PMD=y
 CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES=n
 CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS=n
+
+#
+# Compile the ACL test application
+#
+CONFIG_RTE_APP_ACL_TEST=y
+
+#
+# Compile the pipeline test application
+#
+CONFIG_RTE_APP_PIPELINE_TEST=y
+
+#
+# Compile the ACL test application
+#
+CONFIG_RTE_APP_CMDLINE_TEST=y
+
+#
+# Compile the proc_info test application
+#
+CONFIG_RTE_APP_PROC_INFO=y
+