[dpdk-dev] doc: update user guide about e1000em limitations

Message ID 1446196988-3634-1-git-send-email-yong.liu@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Marvin Liu Oct. 30, 2015, 9:23 a.m. UTC
  Update interrupt related limitations for e1000em nic.
It only support one interrupt source and not support auto-clear.

Signed-off-by: Marvin Liu <yong.liu@intel.com>
  

Comments

John McNamara Nov. 13, 2015, 5:26 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yong Liu
> Sent: Friday, October 30, 2015 9:23 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: update user guide about e1000em
> limitations
> 
> Update interrupt related limitations for e1000em nic.
> It only support one interrupt source and not support auto-clear.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> 
> diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst
> index fedafad..a84e8e1 100644
> --- a/doc/guides/nics/e1000em.rst
> +++ b/doc/guides/nics/e1000em.rst
> @@ -176,3 +176,7 @@ The following are known limitations:
>      testpmd [options] -- --mbuf-size=<your-max-packet-size>
> 
>  #.  Qemu e1000 does not validate the checksum of incoming packets.
> +
> +#.  Qemu e1000 only support one interrupt source, so link and Rx
> interrupt should be exclusive.
> +
> +#.  Qemu e1000 does not support interrupt auto-clear, application should
> disable interrupt immediately when waked up.

Hi Marvin,

Thanks for the clarification. Two minor typos:

    Qemu e1000 only supports one interrupt source ...

    ... disable interrupt immediately when woken up.

When changes are made:

Acked-by: John McNamara <john.mcnamara@intel.com>
  
Thomas Monjalon Dec. 13, 2015, 11:07 p.m. UTC | #2
> > Update interrupt related limitations for e1000em nic.
> > It only support one interrupt source and not support auto-clear.
> > 
> > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > 
> > diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst
> > index fedafad..a84e8e1 100644
> > --- a/doc/guides/nics/e1000em.rst
> > +++ b/doc/guides/nics/e1000em.rst
> > @@ -176,3 +176,7 @@ The following are known limitations:
> >      testpmd [options] -- --mbuf-size=<your-max-packet-size>
> > 
> >  #.  Qemu e1000 does not validate the checksum of incoming packets.
> > +
> > +#.  Qemu e1000 only support one interrupt source, so link and Rx
> > interrupt should be exclusive.
> > +
> > +#.  Qemu e1000 does not support interrupt auto-clear, application should
> > disable interrupt immediately when waked up.
> 
> Hi Marvin,
> 
> Thanks for the clarification. Two minor typos:
> 
>     Qemu e1000 only supports one interrupt source ...
> 
>     ... disable interrupt immediately when woken up.
> 
> When changes are made:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied with changes, thanks
  

Patch

diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst
index fedafad..a84e8e1 100644
--- a/doc/guides/nics/e1000em.rst
+++ b/doc/guides/nics/e1000em.rst
@@ -176,3 +176,7 @@  The following are known limitations:
     testpmd [options] -- --mbuf-size=<your-max-packet-size>
 
 #.  Qemu e1000 does not validate the checksum of incoming packets.
+
+#.  Qemu e1000 only support one interrupt source, so link and Rx interrupt should be exclusive.
+
+#.  Qemu e1000 does not support interrupt auto-clear, application should disable interrupt immediately when waked up.