[dpdk-dev] ixgbe: add mspdc to rx errors

Message ID 1445941334-32248-1-git-send-email-harry.van.haaren@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Van Haaren, Harry Oct. 27, 2015, 10:22 a.m. UTC
  This patch adds the mspdc (MAC Short Packet Discard Count)
to the total rx errors, as discussed on the dev@dpdk mailing
list: http://comments.gmane.org/gmane.comp.networking.dpdk.devel/23717

Suggested-by: Igor Ryzhov <iryzhov@arccn.ru>
Signed-off-by: Harry van Haaren <harry.van.haaren@gmail.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Wenzhuo Lu Oct. 28, 2015, 2:13 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Tuesday, October 27, 2015 6:22 PM
> To: dev@dpdk.org
> Cc: Harry van Haaren
> Subject: [dpdk-dev] [PATCH] ixgbe: add mspdc to rx errors
> 
> This patch adds the mspdc (MAC Short Packet Discard Count) to the total rx
> errors, as discussed on the dev@dpdk mailing
> list: http://comments.gmane.org/gmane.comp.networking.dpdk.devel/23717
> 
> Suggested-by: Igor Ryzhov <iryzhov@arccn.ru>
> Signed-off-by: Harry van Haaren <harry.van.haaren@gmail.com>
Yes, why not including it in the error counter :)
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
  
Thomas Monjalon Oct. 28, 2015, 2:15 p.m. UTC | #2
> > This patch adds the mspdc (MAC Short Packet Discard Count) to the total rx
> > errors, as discussed on the dev@dpdk mailing
> > list: http://comments.gmane.org/gmane.comp.networking.dpdk.devel/23717
> > 
> > Suggested-by: Igor Ryzhov <iryzhov@arccn.ru>
> > Signed-off-by: Harry van Haaren <harry.van.haaren@gmail.com>
> Yes, why not including it in the error counter :)
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Thanks for thinking to add Suggested-by tag.
Applied, thanks
  

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ec2918c..3221615 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2196,6 +2196,7 @@  ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 
 	/* Rx Errors */
 	stats->ierrors  = hw_stats->crcerrs +
+	                  hw_stats->mspdc +
 	                  hw_stats->rlec +
 	                  hw_stats->ruc +
 	                  hw_stats->roc +