Message ID | 1445420342-25227-1-git-send-email-john.mcnamara@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id DEC7C93B6; Wed, 21 Oct 2015 11:39:14 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B02A893B4 for <dev@dpdk.org>; Wed, 21 Oct 2015 11:39:13 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 21 Oct 2015 02:39:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,711,1437462000"; d="scan'208";a="815993756" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 21 Oct 2015 02:39:13 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t9L9dANb027120; Wed, 21 Oct 2015 10:39:10 +0100 Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id t9L9dAIV025274; Wed, 21 Oct 2015 10:39:10 +0100 Received: (from jmcnam2@localhost) by sivswdev02.ir.intel.com with id t9L9dAag025268; Wed, 21 Oct 2015 10:39:10 +0100 From: John McNamara <john.mcnamara@intel.com> To: dev@dpdk.org Date: Wed, 21 Oct 2015 10:39:02 +0100 Message-Id: <1445420342-25227-1-git-send-email-john.mcnamara@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1445340689-32625-1-git-send-email-john.mcnamara@intel.com> References: <1445340689-32625-1-git-send-email-john.mcnamara@intel.com> Subject: [dpdk-dev] [PATCH v2] doc: change sphinx theme to the read the docs theme X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
John McNamara
Oct. 21, 2015, 9:39 a.m. UTC
Change the Sphinx default theme from "alabaster" to the ReadTheDocs
theme. See for example:
http://dpdk.readthedocs.org/en/latest/
This looks better for technical documentation and in particular
it has a 80 char wide verbatim block rendering.
Also turn off option for distracting Html mouseover permalinks.
Signed-off-by: John McNamara <john.mcnamara@intel.com>
---
v2:
* Add version check since rtd theme is only available, by default,
in Sphinx 1.3.1 and later.
doc/guides/conf.py | 4 ++++
1 file changed, 4 insertions(+)
Comments
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John McNamara > Sent: Wednesday, October 21, 2015 10:39 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] doc: change sphinx theme to the read the docs theme > > Change the Sphinx default theme from "alabaster" to the ReadTheDocs > theme. See for example: > > http://dpdk.readthedocs.org/en/latest/ > > This looks better for technical documentation and in particular > it has a 80 char wide verbatim block rendering. > > Also turn off option for distracting Html mouseover permalinks. > > Signed-off-by: John McNamara <john.mcnamara@intel.com> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
2015-10-21 10:39, John McNamara: > Change the Sphinx default theme from "alabaster" to the ReadTheDocs > theme. See for example: > > http://dpdk.readthedocs.org/en/latest/ > > This looks better for technical documentation and in particular > it has a 80 char wide verbatim block rendering. Yes it is a clean theme. It would be nice to add the DPDK logo somewhere. > Also turn off option for distracting Html mouseover permalinks. [...] > +html_add_permalinks = "" I think the permalinks are very useful to point a specific doc chapter to someone else.
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, October 26, 2015 2:34 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: change sphinx theme to the read > the docs theme > > 2015-10-21 10:39, John McNamara: > > Change the Sphinx default theme from "alabaster" to the ReadTheDocs > > theme. See for example: > > > > http://dpdk.readthedocs.org/en/latest/ > > > > This looks better for technical documentation and in particular it has > > a 80 char wide verbatim block rendering. > > Yes it is a clean theme. > It would be nice to add the DPDK logo somewhere. Hi, I'll submit a V3 with a logo for the html and pdf docs. Note, the SVG logos are quite big (2 are required) and converting them to pdf for the Latex pdf docs requires another addition to the makefiles. This is a case where the patch would be smaller and simpler with PNG files and where the images are unlikely to require editing. > > Also turn off option for distracting Html mouseover permalinks. > [...] > > +html_add_permalinks = "" > > I think the permalinks are very useful to point a specific doc chapter to > someone else. It is just as easy to get a link to a subsection from the index. The permalinks are distracting because they blink on and off when scrolling through the docs. Also, I doubt more than a handful of people will know what the permalinks in the Html docs are. Anyway, I'll remove this part from the patch and submit it separately. If there is any support for it the patch can be applied, if not then you can reject it. John. --
2015-11-01 16:41, Mcnamara, John: > I'll submit a V3 with a logo for the html and pdf docs. > > Note, the SVG logos are quite big (2 are required) and converting them to pdf for the Latex pdf docs requires another addition to the makefiles. This is a case where the patch would be smaller and simpler with PNG files and where the images are unlikely to require editing. Yes the logo files are huge and mainly binary data. There is no interest in importing them in git until they are real vector images. I'm in favor of importing a PNG with a reasonable resolution.
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Sunday, November 1, 2015 6:37 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: change sphinx theme to the read > the docs theme > > 2015-11-01 16:41, Mcnamara, John: > > I'll submit a V3 with a logo for the html and pdf docs. > > > > Note, the SVG logos are quite big (2 are required) and converting them > to pdf for the Latex pdf docs requires another addition to the makefiles. > This is a case where the patch would be smaller and simpler with PNG files > and where the images are unlikely to require editing. > > Yes the logo files are huge and mainly binary data. > There is no interest in importing them in git until they are real vector > images. > I'm in favor of importing a PNG with a reasonable resolution. Ok. I'll resubmit with 2 png logos. John. --
diff --git a/doc/guides/conf.py b/doc/guides/conf.py index b2290b4..a87bb06 100644 --- a/doc/guides/conf.py +++ b/doc/guides/conf.py @@ -37,6 +37,10 @@ from pygments.formatters.latex import LatexFormatter project = 'DPDK' +if LooseVersion(sphinx_version) >= LooseVersion('1.3.1'): + html_theme = "sphinx_rtd_theme" + +html_add_permalinks = "" html_show_copyright = False highlight_language = 'none'