[dpdk-dev] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter

  The tx_rate unit is Mbps.

Gleaned from the ixgbe implementation, the 82599 datasheet and the use
in test-pmd.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
---
 lib/librte_ether/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Ping?

// Simon

On 2015-10-20 15:20, Simon Kagstrom wrote:
> The tx_rate unit is Mbps.
> 
> Gleaned from the ixgbe implementation, the 82599 datasheet and the use
> in test-pmd.
> 
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
>  lib/librte_ether/rte_ethdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 8a8c82b..ff9aab7 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
>   * @param queue_idx
>   *   The queue id.
>   * @param tx_rate
> - *   The tx rate allocated from the total link speed for this queue.
> + *   The tx rate in Mbps. Allocated from the total port link speed.
>   * @return
>   *   - (0) if successful.
>   *   - (-ENOTSUP) if hardware doesn't support this feature.
>
  

On Wed, 4 Nov 2015 08:51:03 +0100
Simon Kågström <simon.kagstrom@netinsight.net> wrote:

> Ping?
> 
> // Simon
> 
> On 2015-10-20 15:20, Simon Kagstrom wrote:
> > The tx_rate unit is Mbps.
> > 
> > Gleaned from the ixgbe implementation, the 82599 datasheet and the use
> > in test-pmd.
> > 
> > Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> > ---
> >  lib/librte_ether/rte_ethdev.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> > index 8a8c82b..ff9aab7 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
> >   * @param queue_idx
> >   *   The queue id.
> >   * @param tx_rate
> > - *   The tx rate allocated from the total link speed for this queue.
> > + *   The tx rate in Mbps. Allocated from the total port link speed.
> >   * @return
> >   *   - (0) if successful.
> >   *   - (-ENOTSUP) if hardware doesn't support this feature.
> > 

You can check for status of any/all patches in patchwork:
  http://dpdk.org/dev/patchwork/project/dpdk/list/
  

2015-10-20 15:20, Simon Kagstrom:
> The tx_rate unit is Mbps.
> 
> Gleaned from the ixgbe implementation, the 82599 datasheet and the use
> in test-pmd.
> 
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>

Applied, thanks