[dpdk-dev] doc: remove dejavu font from doc build

Message ID 1445340730-32687-1-git-send-email-john.mcnamara@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

John McNamara Oct. 20, 2015, 11:32 a.m. UTC
  Remove requirement for occasionally hard to find/install
DejaVuSansMono font. It isn't gnerally required anyway.
The default mono font is sufficient.

Signed-off-by: John McNamara <john.mcnamara@intel.com>
---
 doc/guides/conf.py | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Van Haaren, Harry Oct. 23, 2015, 4:09 p.m. UTC | #1
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John McNamara
> Sent: Tuesday, October 20, 2015 12:32 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: remove dejavu font from doc build
> 
> Remove requirement for occasionally hard to find/install
> DejaVuSansMono font. It isn't gnerally required anyway.
> The default mono font is sufficient.
> 
> Signed-off-by: John McNamara <john.mcnamara@intel.com>

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
  
Thomas Monjalon Oct. 26, 2015, 2:24 p.m. UTC | #2
2015-10-20 12:32, John McNamara:
> Remove requirement for occasionally hard to find/install
> DejaVuSansMono font. It isn't gnerally required anyway.
> The default mono font is sufficient.

Does it remove the need for texlive-collection-fontsextra?
  
John McNamara Oct. 26, 2015, 5:35 p.m. UTC | #3
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, October 26, 2015 2:25 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: remove dejavu font from doc build
> 
> 2015-10-20 12:32, John McNamara:
> > Remove requirement for occasionally hard to find/install
> > DejaVuSansMono font. It isn't gnerally required anyway.
> > The default mono font is sufficient.
> 
> Does it remove the need for texlive-collection-fontsextra?

Hi Thomas,

Possibly. I'll need to test to make sure. I'll let you know.

John.
--
  
John McNamara Oct. 29, 2015, 11:35 a.m. UTC | #4
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, October 26, 2015 2:25 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: remove dejavu font from doc build
> 
> 2015-10-20 12:32, John McNamara:
> > Remove requirement for occasionally hard to find/install
> > DejaVuSansMono font. It isn't gnerally required anyway.
> > The default mono font is sufficient.
> 
> Does it remove the need for texlive-collection-fontsextra?

Hi,

I checked and it does remove the requirement for texlive-fonts-recommended in Ubuntu and texlive-collection-fontsextra in Fedora.

I'll submit a v2 with those requirements removed from the Documentation Guidelines.

John.
--
  
Thomas Monjalon Oct. 29, 2015, 12:17 p.m. UTC | #5
2015-10-29 11:35, Mcnamara, John:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-10-20 12:32, John McNamara:
> > > Remove requirement for occasionally hard to find/install
> > > DejaVuSansMono font. It isn't gnerally required anyway.
> > > The default mono font is sufficient.
> > 
> > Does it remove the need for texlive-collection-fontsextra?
> 
> Hi,
> 
> I checked and it does remove the requirement for texlive-fonts-recommended in Ubuntu and texlive-collection-fontsextra in Fedora.
> 
> I'll submit a v2 with those requirements removed from the Documentation Guidelines.

Please remove it from the RPM packaging script also.
Thanks
  

Patch

diff --git a/doc/guides/conf.py b/doc/guides/conf.py
index 8cfb7d3..e060462 100644
--- a/doc/guides/conf.py
+++ b/doc/guides/conf.py
@@ -61,7 +61,6 @@  latex_documents = [
 # Latex directives to be included directly in the latex/pdf docs.
 latex_preamble = r"""
 \usepackage[utf8]{inputenc}
-\usepackage{DejaVuSansMono}
 \usepackage[T1]{fontenc}
 \usepackage{helvet}
 \renewcommand{\familydefault}{\sfdefault}