diff mbox

[dpdk-dev,v3] ixgbe: remove rx jabber from ierrors

Message ID 1445332999-21774-1-git-send-email-harry.van.haaren@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Van Haaren, Harry Oct. 20, 2015, 9:23 a.m. UTC 
  Remove receive jabber count (rjc) from ierrors count as the
register overlaps with the CRC error register, previously
causing some packets to be counted twice.

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---

v3: Add details about register overlap
v2: Fix typo

 drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tahhan, Maryam Oct. 20, 2015, 9:38 a.m. UTC | #1 
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Tuesday, October 20, 2015 10:23 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] ixgbe: remove rx jabber from ierrors
> 
> Remove receive jabber count (rjc) from ierrors count as the register overlaps
> with the CRC error register, previously causing some packets to be counted
> twice.
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> 
> v3: Add details about register overlap
> v2: Fix typo
> 
>  drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ec2918c..6e20e06 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2206,7 +2206,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev,
> struct rte_eth_stats *stats)
>  	                  hw_stats->mlfc +
>  	                  hw_stats->mrfc +
>  	                  hw_stats->rfc +
> -	                  hw_stats->rjc +
>  	                  hw_stats->fccrc +
>  	                  hw_stats->fclast;
> 
> --
> 1.9.1

Acked-by: Maryam Tahhan <maryam.tahhan@intel.com>
Wenzhuo Lu Oct. 21, 2015, 12:54 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Van Haaren, Harry
> Sent: Tuesday, October 20, 2015 5:23 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; Van Haaren, Harry
> Subject: [PATCH v3] ixgbe: remove rx jabber from ierrors
> 
> Remove receive jabber count (rjc) from ierrors count as the register overlaps
> with the CRC error register, previously causing some packets to be counted
> twice.
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Thomas Monjalon Oct. 28, 2015, 2:11 p.m. UTC | #3 
> > Remove receive jabber count (rjc) from ierrors count as the register overlaps
> > with the CRC error register, previously causing some packets to be counted
> > twice.
> > 
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ec2918c..6e20e06 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2206,7 +2206,6 @@  ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	                  hw_stats->mlfc +
 	                  hw_stats->mrfc +
 	                  hw_stats->rfc +
-	                  hw_stats->rjc +
 	                  hw_stats->fccrc +
 	                  hw_stats->fclast;