Message ID | 3042915272161B4EB253DA4D77EB373A14E09865@IRSMSX102.ger.corp.intel.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C19358E92; Thu, 15 Oct 2015 10:42:29 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BB3A68DA7 for <dev@dpdk.org>; Thu, 15 Oct 2015 10:42:27 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 15 Oct 2015 01:42:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,684,1437462000"; d="scan'208";a="581209689" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 15 Oct 2015 01:42:26 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 15 Oct 2015 09:42:25 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.98]) by IRSMSX156.ger.corp.intel.com ([169.254.3.245]) with mapi id 14.03.0248.002; Thu, 15 Oct 2015 09:42:24 +0100 From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com> To: Tetsuya Mukawa <mukawa@igel.co.jp>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss configuration Thread-Index: AQHQ+4oSJjUzlIa1wECZ9omjooFzmZ5sM0wAgAAfLBA= Date: Thu, 15 Oct 2015 08:42:23 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14E09865@IRSMSX102.ger.corp.intel.com> References: <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com> <1443621905-7872-5-git-send-email-tomaszx.kulasek@intel.com> <561F59C8.1070105@igel.co.jp> In-Reply-To: <561F59C8.1070105@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Tomasz Kulasek
Oct. 15, 2015, 8:42 a.m. UTC
> -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > Sent: Thursday, October 15, 2015 09:46 > To: Kulasek, TomaszX; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss > configuration > > On 2015/09/30 23:05, Tomasz Kulasek wrote: > > This implementation allows to set and read RSS configuration for null > > device, and is used to validate right values propagation over the > > slaves, in test units for dynamic RSS configuration for bonding. > > > > v5 changes: > > - replaced memcpy with rte_memcpy > > > > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> > > --- > > drivers/net/null/rte_eth_null.c | 116 > > +++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 116 insertions(+) > > > > diff --git a/drivers/net/null/rte_eth_null.c > > b/drivers/net/null/rte_eth_null.c index bf81b1b..b01f647 100644 > > --- a/drivers/net/null/rte_eth_null.c > > +++ b/drivers/net/null/rte_eth_null.c > > @@ -37,6 +37,8 @@ > > #include <rte_memcpy.h> > > #include <rte_dev.h> > > #include <rte_kvargs.h> > > +#include <rte_eth_null.h> > > +#include <rte_spinlock.h> > > > > > > > Hi Tomasz, > > We don't have "rte_eth_null.h" at this point. > (The header file will be added next patch) Probably, we also need > "rte_pmd_null_version.map" to compile correctly. > (To make sure, please compile DPDK with "CONFIG_RTE_BUILD_SHARED_LIB=y" > option.) > > Also, it seems 'rte_eth_null.h' should be included like below. > #include "rte_eth_null.h" > Without it, we cannot compile. > > Thanks, > Tetsuya Hi Tetsuya, This file and modifications are already included in "[dpdk-dev,v5,5/9] null: export eth_dev_null_create" in the patch set, also the required symlink is created like below: --- --- Tomasz.
Comments
On 2015/10/15 17:42, Kulasek, TomaszX wrote: >> -----Original Message----- >> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] >> Sent: Thursday, October 15, 2015 09:46 >> To: Kulasek, TomaszX; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss >> configuration >> >> On 2015/09/30 23:05, Tomasz Kulasek wrote: >>> This implementation allows to set and read RSS configuration for null >>> device, and is used to validate right values propagation over the >>> slaves, in test units for dynamic RSS configuration for bonding. >>> >>> v5 changes: >>> - replaced memcpy with rte_memcpy >>> >>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> >>> --- >>> drivers/net/null/rte_eth_null.c | 116 >>> +++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 116 insertions(+) >>> >>> diff --git a/drivers/net/null/rte_eth_null.c >>> b/drivers/net/null/rte_eth_null.c index bf81b1b..b01f647 100644 >>> --- a/drivers/net/null/rte_eth_null.c >>> +++ b/drivers/net/null/rte_eth_null.c >>> @@ -37,6 +37,8 @@ >>> #include <rte_memcpy.h> >>> #include <rte_dev.h> >>> #include <rte_kvargs.h> >>> +#include <rte_eth_null.h> >>> +#include <rte_spinlock.h> >>> >>> >> >> Hi Tomasz, >> >> We don't have "rte_eth_null.h" at this point. >> (The header file will be added next patch) Probably, we also need >> "rte_pmd_null_version.map" to compile correctly. >> (To make sure, please compile DPDK with "CONFIG_RTE_BUILD_SHARED_LIB=y" >> option.) >> >> Also, it seems 'rte_eth_null.h' should be included like below. >> #include "rte_eth_null.h" >> Without it, we cannot compile. >> >> Thanks, >> Tetsuya > Hi Tetsuya, > > This file and modifications are already included in "[dpdk-dev,v5,5/9] null: export eth_dev_null_create" in the patch set, also the required symlink is created like below: Hi Tomasz, But "rte_eth_null.h" is used in " [PATCH v5 4/9] null: virtual dynamic rss configuration". It means we cannot compile DPDK before applying "[dpdk-dev,v5,5/9]". When we need to use git-bisect, this will be problem. So could you please keep DPDK being able to compile at any point? Thanks, Tetsuya,
diff --git a/drivers/net/null/Makefile b/drivers/net/null/Makefile index 96ba01c..2202389 100644 --- a/drivers/net/null/Makefile +++ b/drivers/net/null/Makefile @@ -51,7 +51,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += rte_eth_null.c # # Export include files # -SYMLINK-y-include += +SYMLINK-y-include += rte_eth_null.h # this lib depends upon: DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_mbuf