[dpdk-dev,v2] ixgbe: remove rx jabber from ierrors

  Remove receive jabber count from ierrors count as the
registers overlap, previously causing some packets to
be counted twice.

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
v2: Fixed typo

 drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
 1 file changed, 1 deletion(-)
  

Hi Harry,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Thursday, October 15, 2015 1:12 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors
> 
> Remove receive jabber count from ierrors count as the registers overlap,
> previously causing some packets to be counted twice.
Would you like to let us know which register RJC overlaps into? Thanks.

> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> v2: Fixed typo
> 
>  drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ec2918c..6e20e06 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2206,7 +2206,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev,
> struct rte_eth_stats *stats)
>  	                  hw_stats->mlfc +
>  	                  hw_stats->mrfc +
>  	                  hw_stats->rfc +
> -	                  hw_stats->rjc +
>  	                  hw_stats->fccrc +
>  	                  hw_stats->fclast;
> 
> --
> 1.9.1
  

Hi Wenzhuo,

> From: Lu, Wenzhuo
> > Remove receive jabber count from ierrors count as the registers overlap,
> > previously causing some packets to be counted twice.
>
> Would you like to let us know which register RJC overlaps into? Thanks.

It seems that the RJC register overlaps with CRC errors.

Thanks for looking at this patch, -Harry
  

Hi Harry,

> -----Original Message-----
> From: Van Haaren, Harry
> Sent: Tuesday, October 20, 2015 4:30 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors
> 
> Hi Wenzhuo,
> 
> > From: Lu, Wenzhuo
> > > Remove receive jabber count from ierrors count as the registers
> > > overlap, previously causing some packets to be counted twice.
> >
> > Would you like to let us know which register RJC overlaps into? Thanks.
> 
> It seems that the RJC register overlaps with CRC errors.
> 
> Thanks for looking at this patch, -Harry
Yes, you're right. Would you like to add this info to the comments? It'll help to make things clear. Thanks.