[dpdk-dev,testpmd] enable lsc to avoid TX stall, TX stall happened in following sequence start show port info 0
Message ID | 1444236843-3000-1-git-send-email-bie.jiuling@gmail.com (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 1109D69C8; Wed, 7 Oct 2015 18:54:25 +0200 (CEST) Received: from mail-qk0-f176.google.com (mail-qk0-f176.google.com [209.85.220.176]) by dpdk.org (Postfix) with ESMTP id 2CC9C5A49 for <dev@dpdk.org>; Wed, 7 Oct 2015 18:54:23 +0200 (CEST) Received: by qkht68 with SMTP id t68so8235715qkh.3 for <dev@dpdk.org>; Wed, 07 Oct 2015 09:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=gb4iOElkMLe9+VjEdlepaal4+CXCiy0MkPkZWGN+3pY=; b=A9dUEt2GuB70OKp8MDrq53e9eumwUE3/Z/iIA0Nj2xlRRafEalvCBtXmN9rQBbfLsU OB2FcSFtt9eQLDYF6CEh+W7xwqH0motgtU5PACuWrhN0JrYikvkWSZxaZGY5XT0kQs0l 8ZBqP/IqE2HNGEWsevBCwegi9D1tYtC3GzyfwR5wrJdgUc4F+W7SKbyKVKCnJiwPbQDM C6is5gaBdYv/zXFLpHlXyR7A5xCyKU9uWjaRsCZSaMswFLvFJMNNPWdBcypbE99BGC4g L3nD7BZxED0DTFRPkL2nCaylT+V8aTy42pH6xpkl9W2+rTcRH+8ATEfSBchlj7195Hdc da8g== X-Received: by 10.55.19.14 with SMTP id d14mr2663294qkh.54.1444236862702; Wed, 07 Oct 2015 09:54:22 -0700 (PDT) Received: from sT510.mapleworks.com (modemcable098.45-37-24.static.videotron.ca. [24.37.45.98]) by smtp.gmail.com with ESMTPSA id b104sm16637733qga.7.2015.10.07.09.54.22 for <dev@dpdk.org> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Oct 2015 09:54:22 -0700 (PDT) From: Jiuling Bie <bie.jiuling@gmail.com> To: dev@dpdk.org Date: Wed, 7 Oct 2015 12:54:03 -0400 Message-Id: <1444236843-3000-1-git-send-email-bie.jiuling@gmail.com> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [testpmd] enable lsc to avoid TX stall, TX stall happened in following sequence start show port info 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Jiuling Bie
Oct. 7, 2015, 4:54 p.m. UTC
--- app/test-pmd/testpmd.c | 1 + 1 file changed, 1 insertion(+)
Comments
Hi Jiuling, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiuling Bie > Sent: Wednesday, October 07, 2015 5:54 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [testpmd] enable lsc to avoid TX stall, TX stall happened > in following sequence start show port info 0 > > --- > app/test-pmd/testpmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 386bf84..45adefa 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1779,6 +1779,7 @@ init_port_config(void) > port = &ports[pid]; > port->dev_conf.rxmode = rx_mode; > port->dev_conf.fdir_conf = fdir_conf; > + port->dev_conf.intr_conf.lsc = 1; > if (nb_rxq > 1) { > port->dev_conf.rx_adv_conf.rss_conf.rss_key = > NULL; > port->dev_conf.rx_adv_conf.rss_conf.rss_hf = > rss_hf; > -- > 1.9.1 Several things about your patch: - It looks like this is your first patch (plus the other one you sent a few minutes later): take a look at http://dpdk.org/dev - You forgot to sign off your patches (use --signoff with git commit) - The title of this patch is too long, shorten it and include more information in the body of the commit message. - I don't know what this patch is trying to solve exactly. It looks like you are saying that there is a bug that makes TX stop when you run the following commands: testpmd> start testpmd> show port info 0 I don't see such bug, could you explain better the steps to reproduce the issue? Thanks, Pablo
Hi Pablo, The issue is related to certain NIC(s). I observed this on Intel 82577LM(em). Basically show port info will read PHY registers to get link status when lsc interrupt was disabled, which caused TX to stop. I don't have other NICs so not sure it is a common issue or not. Regards, Jiuling On Tue, Oct 13, 2015 at 5:07 AM, De Lara Guarch, Pablo < pablo.de.lara.guarch@intel.com> wrote: > Hi Jiuling, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiuling Bie > > Sent: Wednesday, October 07, 2015 5:54 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [testpmd] enable lsc to avoid TX stall, TX stall > happened > > in following sequence start show port info 0 > > > > --- > > app/test-pmd/testpmd.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > > index 386bf84..45adefa 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -1779,6 +1779,7 @@ init_port_config(void) > > port = &ports[pid]; > > port->dev_conf.rxmode = rx_mode; > > port->dev_conf.fdir_conf = fdir_conf; > > + port->dev_conf.intr_conf.lsc = 1; > > if (nb_rxq > 1) { > > port->dev_conf.rx_adv_conf.rss_conf.rss_key = > > NULL; > > port->dev_conf.rx_adv_conf.rss_conf.rss_hf = > > rss_hf; > > -- > > 1.9.1 > > Several things about your patch: > - It looks like this is your first patch (plus the other one you sent a > few minutes later): take a look at http://dpdk.org/dev > - You forgot to sign off your patches (use --signoff with git commit) > - The title of this patch is too long, shorten it and include more > information in the body of the commit message. > - I don't know what this patch is trying to solve exactly. It looks like > you are saying that there is a bug > that makes TX stop when you run the following commands: > testpmd> start > testpmd> show port info 0 > > I don't see such bug, could you explain better the steps to reproduce the > issue? > > Thanks, > Pablo > >
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 386bf84..45adefa 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1779,6 +1779,7 @@ init_port_config(void) port = &ports[pid]; port->dev_conf.rxmode = rx_mode; port->dev_conf.fdir_conf = fdir_conf; + port->dev_conf.intr_conf.lsc = 1; if (nb_rxq > 1) { port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL; port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf;