Message ID | 1443542682-7088-1-git-send-email-francesco.montorsi@gmail.com (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 879B45A89; Tue, 29 Sep 2015 18:06:17 +0200 (CEST) Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 3F14A5A44 for <dev@dpdk.org>; Tue, 29 Sep 2015 18:06:16 +0200 (CEST) Received: by wiclk2 with SMTP id lk2so23324810wic.1 for <dev@dpdk.org>; Tue, 29 Sep 2015 09:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=DG2m6LZ7DbgtL9bKsn2LUkcPYcOHez3841VqOT0fI8Q=; b=LlRMr5aZEjWv7NPkXMnhy6px9fHiisVWUbItLKKoPu88CGDfEP6t5YoLEZZ6FZyQC6 zDt9M/QpXK4Bwm7EhMMRBoUMSb87fNp3cTh7a8WZyYuU9iO8rzNRZfStkAw4d9VHWvy5 1j1R9iZPWm3lmxQ2/ckgN1gYoSSqOc0fqvGYugh8mMejrE5UcLOF5DTvcM1EZf2KAqCq 4UgsMNgbhqQetZpF2hT5kq87DlBIB0hcvGvWyonDg7r4k/soC3DrZ3OwK6RgvfIHJ2CV iaT+jFAd2v4HzFmLI1+i1cg2opPpCmEj6AVaBlBHGVZhLdDXk9ZcHGdUuJ8ZDKSq6bwY 0k0w== X-Received: by 10.180.88.37 with SMTP id bd5mr27894697wib.82.1443542775674; Tue, 29 Sep 2015 09:06:15 -0700 (PDT) Received: from mod-l-fmontorsi.empirix.com ([83.216.166.201]) by smtp.gmail.com with ESMTPSA id fs2sm24635778wib.12.2015.09.29.09.06.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 29 Sep 2015 09:06:14 -0700 (PDT) From: Francesco Montorsi <francesco.montorsi@gmail.com> To: dev@dpdk.org Date: Tue, 29 Sep 2015 18:04:42 +0200 Message-Id: <1443542682-7088-1-git-send-email-francesco.montorsi@gmail.com> X-Mailer: git-send-email 2.5.3.windows.1 Subject: [dpdk-dev] [PATCH] Add error message when trying to use make option T= during build/clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Francesco Montorsi
Sept. 29, 2015, 4:04 p.m. UTC
From: Francesco Montorsi <fmontorsi@empirix.com>
---
mk/rte.sdkbuild.mk | 6 ++++++
1 file changed, 6 insertions(+)
Comments
Hi Francesco, On 09/29/2015 06:04 PM, Francesco Montorsi wrote: > From: Francesco Montorsi <fmontorsi@empirix.com> > > --- > mk/rte.sdkbuild.mk | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk > index 38ec7bd..013aa89 100644 > --- a/mk/rte.sdkbuild.mk > +++ b/mk/rte.sdkbuild.mk > @@ -29,6 +29,12 @@ > # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > +ifdef T > + ifeq ("$(origin T)", "command line") > + $(error "Cannot use T= with a build/clean target") > + endif > +endif > + > # If DESTDIR variable is given, install binary dpdk I tested this patch but it breaks the "make install" command: $ make install T=x86_64-native-linuxapp-gcc make[5]: Nothing to be done for 'depdirs'. Configuration done rte.sdkbuild.mk:34: *** "Cannot use T= with a build/clean target". As the T= argument is given as a command line variable, it is propagated to the "$(MAKE) all" in rte.sdkinstall.mk. So I think it's better to keep the current code as is, except if you have a better idea. Regards, Olivier
Hi Olivier, thanks for reviewing the patch. However for me it is logical that T= option is used for "config" target and then for building/cleaning only O= is used. However it is not logical for me that install target requires T= option instead of O= option... or perhaps I'm missing something? Thanks, Francesco 2015-10-13 15:22 GMT+02:00 Olivier MATZ <olivier.matz@6wind.com>: > Hi Francesco, > > On 09/29/2015 06:04 PM, Francesco Montorsi wrote: > > From: Francesco Montorsi <fmontorsi@empirix.com> > > > > --- > > mk/rte.sdkbuild.mk | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk > > index 38ec7bd..013aa89 100644 > > --- a/mk/rte.sdkbuild.mk > > +++ b/mk/rte.sdkbuild.mk > > @@ -29,6 +29,12 @@ > > # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE > USE > > # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > > > +ifdef T > > + ifeq ("$(origin T)", "command line") > > + $(error "Cannot use T= with a build/clean target") > > + endif > > +endif > > + > > # If DESTDIR variable is given, install binary dpdk > > I tested this patch but it breaks the "make install" command: > > $ make install T=x86_64-native-linuxapp-gcc > make[5]: Nothing to be done for 'depdirs'. > Configuration done > rte.sdkbuild.mk:34: *** "Cannot use T= with a build/clean target". > > As the T= argument is given as a command line variable, it is > propagated to the "$(MAKE) all" in rte.sdkinstall.mk. > So I think it's better to keep the current code as is, except if > you have a better idea. > > Regards, > Olivier >
Hi Francesco, On 10/14/2015 10:02 AM, Francesco wrote: > Hi Olivier, > thanks for reviewing the patch. However for me it is logical that T= > option is used for "config" target and then for building/cleaning only > O= is used. However it is not logical for me that install target > requires T= option instead of O= option... or perhaps I'm missing something? Actually, the current behavior of install target is to build one or several targets from templates given in the T=. To be clear, this line: make install T=*-native-linuxapp-gcc is equivalent to: make config T=i686-native-linuxapp-gcc O=i686-native-linuxapp-gcc make O=i686-native-linuxapp-gcc make config T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc make O=x86_64-native-linuxapp-gcc make config T=x86_x32-native-linuxapp-gcc O=x86_x32-native-linuxapp-gcc make O=x86_x32-native-linuxapp-gcc The target name "install" is probably not well chosen, and that's probably why you are confused. Mario is currently reworking the Makefiles to support the installation of DPDK into a hierachical file system: http://dpdk.org/ml/archives/dev/2015-October/024686.html http://dpdk.org/ml/archives/dev/2015-October/025432.html Regards, Olivier
diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk index 38ec7bd..013aa89 100644 --- a/mk/rte.sdkbuild.mk +++ b/mk/rte.sdkbuild.mk @@ -29,6 +29,12 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +ifdef T + ifeq ("$(origin T)", "command line") + $(error "Cannot use T= with a build/clean target") + endif +endif + # If DESTDIR variable is given, install binary dpdk #