[dpdk-dev] eal:Change log output to DEBUG instead of INFO

  When log level is set to 7 (INFO) these messages are still displayed
and should be set to DEBUG.

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
 lib/librte_eal/common/eal_common_memory.c  | 2 +-
 lib/librte_eal/common/eal_common_timer.c   | 2 +-
 lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
  

Sergio, Anatoly, David,
It is not so obvious to decide the log level. Please comment or ack.

2015-09-10 14:40, Keith Wiles:
> When log level is set to 7 (INFO) these messages are still displayed
> and should be set to DEBUG.
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  lib/librte_eal/common/eal_common_memory.c  | 2 +-
>  lib/librte_eal/common/eal_common_timer.c   | 2 +-
>  lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
> index b647573..6155752 100644
> --- a/lib/librte_eal/common/eal_common_memory.c
> +++ b/lib/librte_eal/common/eal_common_memory.c
> @@ -139,7 +139,7 @@ rte_eal_memdevice_init(void)
>  int
>  rte_eal_memory_init(void)
>  {
> -	RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n");
> +	RTE_LOG(DEBUG, EAL, "Setting up physically contiguous memory...\n");
>  
>  	const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?
>  			rte_eal_hugepage_init() :
> diff --git a/lib/librte_eal/common/eal_common_timer.c b/lib/librte_eal/common/eal_common_timer.c
> index 72371b8..c4227cd 100644
> --- a/lib/librte_eal/common/eal_common_timer.c
> +++ b/lib/librte_eal/common/eal_common_timer.c
> @@ -81,6 +81,6 @@ set_tsc_freq(void)
>  	if (!freq)
>  		freq = estimate_tsc_freq();
>  
> -	RTE_LOG(INFO, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
> +	RTE_LOG(DEBUG, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
>  	eal_tsc_resolution_hz = freq;
>  }
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> index 0e6c48a..e0c13de 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> @@ -904,7 +904,7 @@ pci_vfio_enable(void)
>  
>  	/* return 0 if VFIO modules not loaded */
>  	if (module_vfio_type1 == 0) {
> -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
>  			"skip VFIO support...\n");
>  		return 0;
>  	}
>
  

Hi

Apologies for late reply, was away. Can't comment on other lines, but

> > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > index 0e6c48a..e0c13de 100644
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> >
> >  	/* return 0 if VFIO modules not loaded */
> >  	if (module_vfio_type1 == 0) {
> > -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> > +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
> >  			"skip VFIO support...\n");
> >  		return 0;
> >  	}
> >
> 

Should people be forced to recompile DPDK with debug logs (and get all this
additional debug output) just to see why VFIO doesn't get initialized? I would
argue this message is not as serious an annoyance to warrant this change, but
maybe Keith has a different opinion.

Either way, I don't feel strongly for or against the change.

Thanks,
Anatoly
  

2016-02-18 10:18, Burakov, Anatoly:
> > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> > >
> > >  	/* return 0 if VFIO modules not loaded */
> > >  	if (module_vfio_type1 == 0) {
> > > -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> > > +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
> > >  			"skip VFIO support...\n");
> > >  		return 0;
> > >  	}
> 
> Should people be forced to recompile DPDK with debug logs (and get all this
> additional debug output) just to see why VFIO doesn't get initialized?

No, there is a run-time option --log-level.
The compiled max level must be set to DEBUG to be able to see this message
with debug --log-level.

> I would
> argue this message is not as serious an annoyance to warrant this change, but
> maybe Keith has a different opinion.
> 
> Either way, I don't feel strongly for or against the change.

Thanks
  

Hi Thomas,

> 2016-02-18 10:18, Burakov, Anatoly:
> > > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> > > >
> > > >  	/* return 0 if VFIO modules not loaded */
> > > >  	if (module_vfio_type1 == 0) {
> > > > -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> > > > +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
> > > >  			"skip VFIO support...\n");
> > > >  		return 0;
> > > >  	}
> >
> > Should people be forced to recompile DPDK with debug logs (and get all
> > this additional debug output) just to see why VFIO doesn't get initialized?
> 
> No, there is a run-time option --log-level.
> The compiled max level must be set to DEBUG to be able to see this message
> with debug --log-level.

Apologies, I wasn't aware of this feature. No objections then.

Thanks,
Anatoly
  

2015-09-10 14:40, Keith Wiles:
> When log level is set to 7 (INFO) these messages are still displayed
> and should be set to DEBUG.
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>

Applied, thanks