diff mbox

[dpdk-dev,v2,26/32] app/testpmd: initialize receive mode for VMDq

Message ID 1481081535-37448-27-git-send-email-wenzhuo.lu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
checkpatch/checkpatch success coding style OK

Commit Message

Wenzhuo Lu Dec. 7, 2016, 3:32 a.m. UTC 
  Initialise VMDq in the init_port_config function in a similar
way to how it is done in the VMDq sample application.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 app/test-pmd/testpmd.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit Dec. 7, 2016, 3:06 p.m. UTC | #1 
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:
> Initialise VMDq in the init_port_config function in a similar
> way to how it is done in the VMDq sample application.

What is the effect of doing existing initialization?

> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---

<...>
Iremonger, Bernard Dec. 7, 2016, 5 p.m. UTC | #2 
Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 3:07 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 26/32] app/testpmd: initialize receive
> mode for VMDq
> 
> On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:
> > Initialise VMDq in the init_port_config function in a similar way to
> > how it is done in the VMDq sample application.
> 
> What is the effect of doing existing initialization?

This patch results in the function i40e_vmdq_setup() function being called  in i40e_ethdev.c at
Line 1307: ret = i40e_vmdq_setup(dev);

We are seeing unexpected side effects from this patch. 
It will be dropped from the v3 of this patch set, pending further investigation.

Regards,

Bernard.
diff mbox

Patch

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a0332c2..c0c8f60 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1842,9 +1842,12 @@  struct pmd_test_command {
 					ETH_MQ_RX_VMDQ_RSS;
 			else
 				port->dev_conf.rxmode.mq_mode =
-					ETH_MQ_RX_NONE;
+					ETH_MQ_RX_VMDQ_ONLY;
 
 			port->dev_conf.txmode.mq_mode = ETH_MQ_TX_NONE;
+
+			port->dev_conf.rx_adv_conf.vmdq_rx_conf.nb_queue_pools =
+				ETH_8_POOLS;
 		}
 
 		rxtx_port_config(port);