diff mbox

[dpdk-dev] examples: fix ip_pipeline makefile typo

Message ID CAKh5naZ8aOmiN0WkrGKe8J7Mt0R604hhR08PpgAbdwO=6u6M0Q@mail.gmail.com (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
checkpatch/checkpatch success coding style OK

Commit Message

Ilya Matveychikov Nov. 23, 2016, 12:56 p.m. UTC 
  Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
---
 examples/ip_pipeline/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.5.5

Comments

Ferruh Yigit Nov. 23, 2016, 3:43 p.m. UTC | #1 
On 11/23/2016 12:56 PM, Ilya Matveychikov wrote:
> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> ---
>  examples/ip_pipeline/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
> index 5827117..6657237 100644
> --- a/examples/ip_pipeline/Makefile
> +++ b/examples/ip_pipeline/Makefile
> @@ -36,7 +36,7 @@ endif
>  # Default target, can be overridden by command line or environment
>  RTE_TARGET ?= x86_64-native-linuxapp-gcc
> 
> -DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
> +DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline

No need to fix, this line can be removed completely.

Because of:
VPATH += $(SRCDIR)/pipeline

and files handled in this makefile:
SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_passthrough.c

When you fix DIR-y, you also need to add a makefile to pipeline folder
and update this makefile. I guess all those are not required. Just
removing that line is easier J

> 
>  include $(RTE_SDK)/mk/rte.vars.mk
> 
> --
> 2.5.5
>
Thomas Monjalon Jan. 17, 2017, 5:22 p.m. UTC | #2 
2016-11-23 15:43, Ferruh Yigit:
> On 11/23/2016 12:56 PM, Ilya Matveychikov wrote:
> > Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> > ---
> >  examples/ip_pipeline/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
> > index 5827117..6657237 100644
> > --- a/examples/ip_pipeline/Makefile
> > +++ b/examples/ip_pipeline/Makefile
> > @@ -36,7 +36,7 @@ endif
> >  # Default target, can be overridden by command line or environment
> >  RTE_TARGET ?= x86_64-native-linuxapp-gcc
> > 
> > -DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
> > +DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
> 
> No need to fix, this line can be removed completely.
> 
> Because of:
> VPATH += $(SRCDIR)/pipeline
> 
> and files handled in this makefile:
> SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_passthrough.c
> 
> When you fix DIR-y, you also need to add a makefile to pipeline folder
> and update this makefile. I guess all those are not required. Just
> removing that line is easier J

There was no progress on this trivial patch.
So I made what Ferruh suggested and applied in the tree directly:
	http://dpdk.org/commit/45e1c8b

Thanks for the report and the review.
diff mbox

Patch

diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
index 5827117..6657237 100644
--- a/examples/ip_pipeline/Makefile
+++ b/examples/ip_pipeline/Makefile
@@ -36,7 +36,7 @@  endif
 # Default target, can be overridden by command line or environment
 RTE_TARGET ?= x86_64-native-linuxapp-gcc

-DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
+DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline

 include $(RTE_SDK)/mk/rte.vars.mk