diff mbox

[dpdk-dev] scripts: show full headline with checkpatch

Message ID 1478359694-13420-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
tmonjalo/checkpatch success coding style OK

Commit Message

Thomas Monjalon Nov. 5, 2016, 3:28 p.m. UTC 
  The Subject in an email can be split on two lines.
In such case, the second line (starting with a space) can be
joined to the first one.

It is handled differently when parsing stdin or a file.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/checkpatches.sh | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Nov. 6, 2016, 9:35 a.m. UTC | #1 
2016-11-05 16:28, Thomas Monjalon:
> The Subject in an email can be split on two lines.
> In such case, the second line (starting with a space) can be
> joined to the first one.
> 
> It is handled differently when parsing stdin or a file.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied
diff mbox

Patch

diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh
index 619ac21..2f67d24 100755
--- a/scripts/checkpatches.sh
+++ b/scripts/checkpatches.sh
@@ -101,13 +101,16 @@  check () { # <patch> <commit> <title>
 
 if [ -n "$1" ] ; then
 	for patch in "$@" ; do
-		subject=$(sed -n 's,^Subject: ,,p' "$patch")
+		# Subject can be on 2 lines
+		subject=$(sed '/^Subject: */!d;s///;N;s,\n[[:space:]]\+, ,;s,\n.*,,;q' "$patch")
 		check "$patch" '' "$subject"
 	done
 elif [ ! -t 0 ] ; then # stdin
 	subject=$(while read header value ; do
 		if [ "$header" = 'Subject:' ] ; then
-			echo $value
+			IFS= read next
+			continuation=$(echo "$next" | sed -n 's,^[[:space:]]\+, ,p')
+			echo $value$continuation
 			break
 		fi
 	done)