diff mbox

[dpdk-dev,v2,2/2] arch/ppc: fix file descriptor leakage when getting CPU features

Message ID 1478252803-14672-2-git-send-email-jianbo.liu@linaro.org (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
tmonjalo/checkpatch success coding style OK

Commit Message

Jianbo Liu Nov. 4, 2016, 9:46 a.m. UTC 
  close the file descriptor after finish using it.

Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power)

Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
 lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Viktorin Nov. 4, 2016, 11:18 a.m. UTC | #1 
On Fri,  4 Nov 2016 15:16:43 +0530
Jianbo Liu <jianbo.liu@linaro.org> wrote:

> close the file descriptor after finish using it.

s/close/Close/

Please include my ack (below).

Jan

> 
> Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power)
> 
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>

Acked-by: Jan Viktorin <viktorin@rehivetech.com>
Thomas Monjalon Nov. 6, 2016, 9:44 p.m. UTC | #2 
2016-11-04 12:18, Jan Viktorin:
> On Fri,  4 Nov 2016 15:16:43 +0530
> Jianbo Liu <jianbo.liu@linaro.org> wrote:
> 
> > close the file descriptor after finish using it.
> 
> s/close/Close/
> 
> Please include my ack (below).
> 
> Jan
> 
> > 
> > Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power)
> > 
> > Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> 
> Acked-by: Jan Viktorin <viktorin@rehivetech.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
index a8147c8..fcf96e0 100644
--- a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
@@ -116,6 +116,7 @@  rte_cpu_get_features(hwcap_registers_t out)
 		else if (auxv.a_type == AT_HWCAP2)
 			out[REG_HWCAP2] = auxv.a_un.a_val;
 	}
+	close(auxv_fd);
 }
 
 /*