diff mbox

[dpdk-dev] scripts: fix quiet checkpatch

Message ID 1478103009-22581-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
tmonjalo/checkpatch success coding style OK

Commit Message

Thomas Monjalon Nov. 2, 2016, 4:10 p.m. UTC 
  The commit e13fbc065c7f ("scripts: improve quiet checkpatch")
removed the line "total: 1 errors, 0 warnings, 7 lines checked"
from the quiet report.
Later, commit e7c38f471384 ("scripts: remove useless checkpatch notes")
removed few lines before "total:.*lines checked", so it was not working
well for quiet reporting.

Better to keep the "total:" line in quiet mode and remove the other ones.
That's why the checkpatch.pl option --no-summary is not used anymore
by reverting the commit "improve quiet checkpatch".

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Nov. 5, 2016, 2:58 p.m. UTC | #1 
2016-11-02 17:10, Thomas Monjalon:
> The commit e13fbc065c7f ("scripts: improve quiet checkpatch")
> removed the line "total: 1 errors, 0 warnings, 7 lines checked"
> from the quiet report.
> Later, commit e7c38f471384 ("scripts: remove useless checkpatch notes")
> removed few lines before "total:.*lines checked", so it was not working
> well for quiet reporting.
> 
> Better to keep the "total:" line in quiet mode and remove the other ones.
> That's why the checkpatch.pl option --no-summary is not used anymore
> by reverting the commit "improve quiet checkpatch".
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied
diff mbox

Patch

diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh
index 622a5b6..5286fe6 100755
--- a/scripts/checkpatches.sh
+++ b/scripts/checkpatches.sh
@@ -64,7 +64,7 @@  verbose=false
 while getopts hn:qv ARG ; do
 	case $ARG in
 		n ) number=$OPTARG ;;
-		q ) quiet=true && options="$options --no-summary" ;;
+		q ) quiet=true ;;
 		v ) verbose=true ;;
 		h ) print_usage ; exit 0 ;;
 		? ) print_usage ; exit 1 ;;