[dpdk-dev,v3] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time

Message ID 20161101115555.12867-1-nikita@elyzion.net (mailing list archive)
State Accepted, archived
Headers

Commit Message

Nikita Kozlov Nov. 1, 2016, 11:55 a.m. UTC
  num_route_entries need to be reseted.

Fixes: 17d60f5b5eea ("app/test: remove large IPv4 LPM data file")

Signed-off-by: Nikita Kozlov <nikita@elyzion.net>
---
 app/test/test_lpm_perf.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Wei Dai Nov. 3, 2016, 3:28 a.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nikita Kozlov
> Sent: Tuesday, November 1, 2016 7:56 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] app/test: fix a segfault when lpm_perf_autotest
> is run more than 1 time
> 
> num_route_entries need to be reseted.
> 
> Fixes: 17d60f5b5eea ("app/test: remove large IPv4 LPM data file")
> 
> Signed-off-by: Nikita Kozlov <nikita@elyzion.net>
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Tested-by: Wei Dai <wei.dai@intel.com>
Acked-by: Wei Dai <wei.dai@intel.com>
> ---
>  app/test/test_lpm_perf.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index
> 608e17a..e7e1281 100644
> --- a/app/test/test_lpm_perf.c
> +++ b/app/test/test_lpm_perf.c
> @@ -301,6 +301,7 @@ static void generate_large_route_rule_table(void)
>  	uint32_t ip_class;
>  	uint8_t  depth;
> 
> +	num_route_entries = 0;
>  	memset(large_route_table, 0, sizeof(large_route_table));
> 
>  	for (ip_class = IP_CLASS_A; ip_class <= IP_CLASS_C; ip_class++) {
> --
> 2.9.2
  
Thomas Monjalon Nov. 6, 2016, 10:55 p.m. UTC | #2
> > num_route_entries need to be reseted.
> > 
> > Fixes: 17d60f5b5eea ("app/test: remove large IPv4 LPM data file")
> > 
> > Signed-off-by: Nikita Kozlov <nikita@elyzion.net>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> Tested-by: Wei Dai <wei.dai@intel.com>
> Acked-by: Wei Dai <wei.dai@intel.com>

Appplied, thanks
  

Patch

diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index 608e17a..e7e1281 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -301,6 +301,7 @@  static void generate_large_route_rule_table(void)
 	uint32_t ip_class;
 	uint8_t  depth;
 
+	num_route_entries = 0;
 	memset(large_route_table, 0, sizeof(large_route_table));
 
 	for (ip_class = IP_CLASS_A; ip_class <= IP_CLASS_C; ip_class++) {