[dpdk-dev] net/mlx5: fix hash key size retrieval

Message ID 494dd0993d87719c80fc6caa9b4586bd3deaa016.1476430165.git.nelio.laranjeiro@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

NĂ©lio Laranjeiro Oct. 14, 2016, 7:30 a.m. UTC
  Return RSS key size in struct rte_eth_dev_info.

Fixes: 0f6f219e7919 ("app/testpmd: fix RSS hash key size")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Adrien Mazarguil Oct. 14, 2016, 8:20 a.m. UTC | #1
On Fri, Oct 14, 2016 at 09:30:14AM +0200, Nelio Laranjeiro wrote:
> Return RSS key size in struct rte_eth_dev_info.
> 
> Fixes: 0f6f219e7919 ("app/testpmd: fix RSS hash key size")
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

> ---
>  drivers/net/mlx5/mlx5_ethdev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index c1c2d26..b8b3ea9 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -601,6 +601,9 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
>  	 * size if it is not fixed.
>  	 * The API should be updated to solve this problem. */
>  	info->reta_size = priv->ind_table_max_size;
> +	info->hash_key_size = ((*priv->rss_conf) ?
> +			       (*priv->rss_conf)[0]->rss_key_len :
> +			       0);
>  	info->speed_capa =
>  			ETH_LINK_SPEED_1G |
>  			ETH_LINK_SPEED_10G |
> -- 
> 2.1.4
>
  
Bruce Richardson Oct. 19, 2016, 9:26 a.m. UTC | #2
On Fri, Oct 14, 2016 at 10:20:32AM +0200, Adrien Mazarguil wrote:
> On Fri, Oct 14, 2016 at 09:30:14AM +0200, Nelio Laranjeiro wrote:
> > Return RSS key size in struct rte_eth_dev_info.
> > 
> > Fixes: 0f6f219e7919 ("app/testpmd: fix RSS hash key size")
> > 
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
Applied to dpdk-next-net/rel_16_11

/Bruce
  

Patch

diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index c1c2d26..b8b3ea9 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -601,6 +601,9 @@  mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
 	 * size if it is not fixed.
 	 * The API should be updated to solve this problem. */
 	info->reta_size = priv->ind_table_max_size;
+	info->hash_key_size = ((*priv->rss_conf) ?
+			       (*priv->rss_conf)[0]->rss_key_len :
+			       0);
 	info->speed_capa =
 			ETH_LINK_SPEED_1G |
 			ETH_LINK_SPEED_10G |