diff mbox

[dpdk-dev] kni: fix build with kernel < v3.0

Message ID 1474042198-10701-1-git-send-email-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Commit Message

Ferruh Yigit Sept. 16, 2016, 4:09 p.m. UTC 
  Compile error:
  CC [M]  .../build/lib/librte_eal/linuxapp/kni/igb_main.o
.../build/lib/librte_eal/linuxapp/kni/igb_main.c:
In function ‘igb_check_swap_media’:
.../build/lib/librte_eal/linuxapp/kni/igb_main.c:1556:7:
error: variable ‘link’ set but not used [-Werror=unused-but-set-variable]
  bool link;
       ^

With Linux kernel >= v3.0 this warning disabled:
Linux: 8417da6f2128 ("kbuild: Fix passing -Wno-* options to gcc 4.4+")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon Sept. 21, 2016, 4:13 p.m. UTC | #1 
2016-09-16 17:09, Ferruh Yigit:
> Compile error:
>   CC [M]  .../build/lib/librte_eal/linuxapp/kni/igb_main.o
> .../build/lib/librte_eal/linuxapp/kni/igb_main.c:
> In function ‘igb_check_swap_media’:
> .../build/lib/librte_eal/linuxapp/kni/igb_main.c:1556:7:
> error: variable ‘link’ set but not used [-Werror=unused-but-set-variable]
>   bool link;
>        ^
> 
> With Linux kernel >= v3.0 this warning disabled:
> Linux: 8417da6f2128 ("kbuild: Fix passing -Wno-* options to gcc 4.4+")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
index 1bb2242..23e2d64 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
@@ -1558,6 +1558,7 @@  static void igb_check_swap_media(struct igb_adapter *adapter)
 	ctrl_ext = E1000_READ_REG(hw, E1000_CTRL_EXT);
 	connsw = E1000_READ_REG(hw, E1000_CONNSW);
 	link = igb_has_link(adapter);
+	(void) link;
 
 	/* need to live swap if current media is copper and we have fiber/serdes
 	 * to go to.