Message ID | 20160826132701.18428-1-skarmarkar@sonusnet.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 3752058D8; Fri, 26 Aug 2016 15:27:36 +0200 (CEST) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0052.outbound.protection.outlook.com [104.47.40.52]) by dpdk.org (Postfix) with ESMTP id 835C558D6 for <dev@dpdk.org>; Fri, 26 Aug 2016 15:27:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GVx/TUGLuIBI/QgEBZLHPaZVROt6z5F2Yps6ayjj2nM=; b=ij28WhrE8YJZ1hAPO3eM6cIFtTsNAm6En2ZmG6ooCfEqZ2vfBuhNTJVxjoAqppucVUD9AyzHkICtUxPn6x82fEdFBWWdGVBbcRe5lJgL/c91LPqZksnjEv4Fji14QpJCvtG2jTQO6LErDHGSCkyk5mP7XUZXJKlsbRnkH44L7VE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=skarmarkar@sonusnet.com; Received: from SKARMARKAR-LMA.sonusnet.com (208.45.178.4) by BY1PR03MB1337.namprd03.prod.outlook.com (10.162.109.19) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.13; Fri, 26 Aug 2016 13:27:29 +0000 From: Karmarkar Suyash <skarmarkar@sonusnet.com> To: <rsanford@akamai.com> CC: <dev@dpdk.org>, Karmarkar Suyash <skarmarkar@sonusnet.com> Date: Fri, 26 Aug 2016 09:27:01 -0400 Message-ID: <20160826132701.18428-1-skarmarkar@sonusnet.com> X-Mailer: git-send-email 2.9.3.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [208.45.178.4] X-ClientProxiedBy: BN3PR0301CA0054.namprd03.prod.outlook.com (10.160.152.150) To BY1PR03MB1337.namprd03.prod.outlook.com (10.162.109.19) X-MS-Office365-Filtering-Correlation-Id: ea424fbb-9b2f-4d68-6d59-08d3cdb4ba8d X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1337; 2:UIbCc3dWJ+dT+kid45UOD8PS4Jc1wpyxDdSZYBMKG0ygYfJ5RqNz30qgaptdLHmcnpB7zBSB3sZ17qe8vLG0ymRBMZUr53Mb5/P6Bq5gE5Nk1pMLfK8MInjginEsJPEQs6GIgIAXNLqOl5HyCpS2XiBr0B2tvDLpl9IfcJLbmqN5xHKKlR78raagIoIc8Mks; 3:EGctLWgPtg896FORPsntFeC1WLqgg6rv6Dk39lKYTfmomH8LouObZWR09Oll2GuDko4V5STrcAgTLAj9+pWC0ki/osXTfz5A7vRwMljMSwhEe/V7q/KUR8XDDs9zuM+B; 25:bJf2qKiYsPYxj5mR5xkqJ4T5YPeGz1QqstB6qSq7aPy2EPsL+jNELYu6aRTOaYFVbMB1PPmI2DZzqgRYJf4W/1aPpazcwojifCzDfzLjgQqkRwKOa1psLqvA2HTF8gnyn2Ehn4jkevdE1PfjL13FLsNKpaWrzNxxBB3BxGG1Ws4RkmoHwLnxImUomg5CYNl/Xh4XZ23pPYJ+E7iES8zKD6ygNNe1FA6EWXEsRClH+z+y58KZ5lLmbKX/TEswndyxliU0GVq7N9MolKy87T+K24HRuYwQTOMhLD82Vz1ZI2o6fPt/Uy9rC7xFVgdBSd2+YEUbgrloD3LY3vcavnt/0yngYKdtJgW9aIv1skfl/ojKjBzm843jufdXvr40sYjOrduY0IQdF/IUE485YsOqk46/FhCXbfwY30deXLbfziw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1337; X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1337; 31:T0Yhd1BPtSxnNqCcaiHRqSGTiCPV5awNG1wY9DxwtyQxZ5JFyNLG7dE3j/jvtz/XnpDhxqjMU0tXSvdsTo2lD9lhcdpOLFwGHRtNxGiTNDhUZd/Ej14W1mkSrMe3X3UK0GYL62BajdHV+zLz7Qdu5+dKgqL/xPE/KWokAsg+eYY4xWNbrqk/aW/WE1ipdgJ2MrXq2cgJXOvEMWNKbA6qNh+iVe4iKusFy5YCizAp2ew=; 20:UQLZJVS1V4Ec93QUXwEAxoc6MNIclAmZIorf1nTQQFE6blZr3bxob7rLlSn1yMnejpyr1rYaF6xkN1BiRhUaoQPXk1Z6WncCTrS3uYmzrgzccJQfaGRLSOYZIuaSLm/P0+KJVucmAhzO8tYeaRN0rCv933qL5uTWHe+qlMYGhkylNfovk5V7sYZ/w4eXq8XExW2nM3qlHOp3G+9g3RwYBCmnnI/uK6B0+QEwJ/jdC2MOntqP7fMa54Z+9mYfm2SF65D0AiQFv5aLRLK2gH2zXQDW1FgKH+tKYPNRDT9z6YT3MmdKwrwxS0uTSiBSIPXo2fvYtkeZ5DOXuxFC45ZD4OFfF4Uo38QRSMO8tvbK9TcelICun8AgAs2cnuj+suus7vGaXtevxtlkINMyy3lQDcgbDMr7NMmoy+us3sXyhemi/QUVguUQELCZp1twnsVLtB497kGSuN+PXkPFKgy9z/Ja0CidxxyiOnkEDvjALcV2Ie77YOAc89QwR3A+M0Hn X-Microsoft-Antispam-PRVS: <BY1PR03MB1337787891363F3DB1CE41EBB3EC0@BY1PR03MB1337.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BY1PR03MB1337; BCL:0; PCL:0; RULEID:; SRVR:BY1PR03MB1337; X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1337; 4:mT2g/qIgXzCBDFUDcLeIiRMcGRJOKV76OroJFlpVLZjnCm3aI7sVf8cbfXR4H7KXfKYvciKODxoLePttQ8uBwV2S+h1RSl+x0ybIy06y7URNXljWhcjqZySbmaqADtQzP1ysuQNlbQ7TcHXt8DF303NswgqahCef/+oDxHzh7zmyey9dlTa0U9xFNXj84WutZZ9xlgZeEF0PwzclMngvucIingz/5kYaCvcBGC3sKFYTWpvFX4zBbtLpVPpkgvCyThC0DFEWmjjsh5EH5g7MLP7rhhT5wqwhSaYO+IVY4VNPllVH5DecV2MkD4j2cmH66e4BITYZDjsZCqfNbE7BF9+Ma8FZFJdmiK9lfkCy1vHpXQg2l5hDAFP3kQKYqFL1okmj6m/QF0TcoB7I7neyNA== X-Forefront-PRVS: 00462943DE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6009001)(7916002)(189002)(199003)(4001430100002)(6116002)(50226002)(3846002)(50466002)(106356001)(586003)(2351001)(229853001)(110136002)(33646002)(97736004)(48376002)(5660300001)(2906002)(5003940100001)(107886002)(53416004)(101416001)(42186005)(69596002)(105586002)(19580395003)(189998001)(8676002)(36756003)(77096005)(575784001)(4326007)(47776003)(68736007)(1076002)(66066001)(81156014)(92566002)(81166006)(50986999)(7846002)(86362001)(305945005)(7736002)(19580405001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR03MB1337; H:SKARMARKAR-LMA.sonusnet.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR03MB1337; 23:klKnHCgQNVCJIw15huPMepjAmNYT7LDPd1NWnNyx/?= =?us-ascii?Q?S7PMRkTsKmJPQUkbySrK41trVTNmhYSpj1pcjomjAxvkltsCKxqFiVWtliUP?= =?us-ascii?Q?FH48mtBOawCV0Q7P1p5IoqMSxnvfIfefDn+6OFL+Jf542MYQnNasQOrLNx0F?= =?us-ascii?Q?scUrVavgm52QxA5oYp7BJbELIqb+1/QT677mq52efucaP+5uUUxn655Yvsjb?= =?us-ascii?Q?g/Rpt1RR6pndv7vWu0vGYPyX9aM2AGXN8DRTluXaY+jOaoFlqOGl14cLsOXr?= =?us-ascii?Q?5mqYcbSeUY11RJ8pxncHC3mUMub0LMQzt9yGxjruIn7tZbFVa0RxBH+Xp2IZ?= =?us-ascii?Q?W/iq0f+8zCkBZ4zvPIv3mzaf81VP0ojLr0MszlznQn8OwbOxhxyAN1VVg9MC?= =?us-ascii?Q?G7nL+5eIBIz3OuVIkqGxEZmM9ux5mO0hntcuKhOVzdep5McRKQC9NZBAnwdG?= =?us-ascii?Q?H3cr4F7wxBDdQoSbLkRc76XDC/5uEltUtcLQjF6fdP3TDIzwgyNkY6uB6M+a?= =?us-ascii?Q?eAOzlEwfuJxar2vgSosxNxEt+yropxh0Pc54Os6wqi8lgKEz2LzRHowNhPwi?= =?us-ascii?Q?e/2QOwvUtQbiAdC+KNopLqPk+MLwAEJIMoR2CBcuyB5VEGVsKHTx9HUDrgjF?= =?us-ascii?Q?kqlpBrpKK5tZA96ePAoqDciSH3itXUqnTLK6SBsaJbxr3znKzUVzEOMMGPrv?= =?us-ascii?Q?m74n7Ne2ZKXeJNNEnlwTD3Txo3YqUGysd+4E7BfZK+NB2gCV+SLRGPfM8TiZ?= =?us-ascii?Q?WzkuGEwwcRVjliCvGUcaYjhVfFKh6BmmbN+pLWTSwWmGLBkufQyJ8DmO9xUq?= =?us-ascii?Q?HeJ2UPkEXDBjunXgKJ9449oqiZtogsgqyNHQ1c+6oHdjh0PgtaEP5OU9HhX+?= =?us-ascii?Q?j9HAxdwPNaf9z4fxAz8f6vxNLcVzmxt51+JiAiLEGJ5F6AMC/VsmyRj4eGW2?= =?us-ascii?Q?U3mt8jA3Xc6YNOJgHB2KLsuN2og/g2AzfyaOOdKioHCT1U5QQU20Dn3KFjdy?= =?us-ascii?Q?sc4e7j0oy6s9BKQNrLrT6vm5158sCYiHQnqGgTrRr5OaqwqK3wEzbghxW6DL?= =?us-ascii?Q?Go5SIjEmzTncXr2L7DKAWuqqjpiLxZIKPEIDiGxQOsymVWPkZg2dzrFfBI9L?= =?us-ascii?Q?vDtK/dWlEu5HGZcjdb5dbScMzr9Jx5ojCD1+l85lS1B9hilm1mD5ThyzC+gE?= =?us-ascii?Q?wJVUxM8HuMRoavPxeOUnnvU8fK3bzNStJ6qX1mE2qtrIdJlvQ6N3x84c85sl?= =?us-ascii?Q?td3wnQSfiSb1wbnpWM=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1337; 6:YCnfNEYGnoSt1wHVs3CoHk+xczvQCpZOsNiWx2eFRJP7n8JNSEp+v+IE0ct1O1Cn1rW8ABd5jgw6ZJpFibAwbJB/cu/2++zymQQV6yXp7QFu2a6KhlfahCdhlB5EyEo0deUa1IWJRoD2MBRIZ5rgqdtWDUZ32UeuBi853enWy/k/IvJQnjwl5+o1fQ8szXgPtaV1y5qXMJVdRvnWPXz3ooyFMn0fG+SO7futtQybG9lNrcE5dS6Y4jx1lNhVl8sOAOSaFfpLady4S+cIrRpup1nuTBcuC3zrLCE2fm134HQ=; 5:PtkTo56KUixIfUSVslOl00EzlaOa6BfBL4TWv5S7ydqBIMTcaQSln4AJkBw47IzqQjYmO4MAwfo12Pxxpj9/zyldczWPb2QBrHkyzu1HMCPhg5O/IBnKq6RaheDSUoO1/lduBKKuBqC3Dsjy5QZwkw==; 24:huIZqRUr8uf4SI9AR5t25DdCyyvxaqv0Y76MeBByxfgUxQVwkZDZwJiqiJrgeB3p1UebVGu+k3yJ92bsdvNhjV3krl6F22xR8zTp9OCQtiE=; 7:vW7S/58yQL0dknlXsypN3qU80WzrGOolYMd0UaRRyIwG9mYkzfTy5Sh4bAdmCv8QoIAjhyQ5dEeM9e0nVQi9hWw0jdKokXun5Qz6JiOEZNWOkYqILnWuGjFee7bugvVO3sgi1iUXis9BUJMxp6lsXGHoXOfPyg+Bt+j7BLYQN3rke3XEddOWRHtjY0xX3qNPqNud+DO7SCH21gKfrcMbodZBoWTtuCfowBS6nmQyzjDbubKFCay7SFwAec993cqw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2016 13:27:29.3066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1337 Subject: [dpdk-dev] [PATCH v1]:rte_timer:timer lag issue correction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Karmarkar Suyash
Aug. 26, 2016, 1:27 p.m. UTC
For Periodic timers ,if the lag gets introduced, the current code added additional delay when the next peridoc timer was initialized by not taking into account the delay added, with this fix the code would start the next occurrence of timer keeping in account the lag added.Corrected the behavior. Fixes:rte_timer: timer lag issue Karmarkar Suyash (1): Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com> lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From ba885531ac26af1aabc6bd0f58d7ce744b04acf7 Mon Sep 17 00:00:00 2001 From: Karmarkar Suyash <skarmarkar@sonusnet.com> Date: Fri, 26 Aug 2016 09:20:37 -0400 Subject: [PATCH v1] Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com> --- lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index 43da836..18782fa 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -613,7 +613,7 @@ void rte_timer_manage(void) status.owner = (int16_t)lcore_id; rte_wmb(); tim->status.u32 = status.u32; - __rte_timer_reset(tim, cur_time + tim->period, + __rte_timer_reset(tim, tim->expire + tim->period, tim->period, lcore_id, tim->f, tim->arg, 1); rte_spinlock_unlock(&priv_timer[lcore_id].list_lock); }