[dpdk-dev] nfp: unregister interrupt callback function when closing device
Commit Message
With an app using hotplug feature, when a device is unplugged without
unregistering makes the interrupt handling unstable.
Fixes: 6c53f87b3497 ("nfp: add link status interrupt")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 5 +++++
1 file changed, 5 insertions(+)
Comments
On 8/16/2016 4:57 PM, Alejandro Lucero wrote:
> With an app using hotplug feature, when a device is unplugged without
> unregistering makes the interrupt handling unstable.
>
> Fixes: 6c53f87b3497 ("nfp: add link status interrupt")
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Headline too long:
nfp: unregister interrupt callback function when closing device
@@ -733,6 +733,11 @@ nfp_net_close(struct rte_eth_dev *dev)
rte_intr_disable(&dev->pci_dev->intr_handle);
nn_cfg_writeb(hw, NFP_NET_CFG_LSC, 0xff);
+ /* unregister callback func from eal lib */
+ rte_intr_callback_unregister(&dev->pci_dev->intr_handle,
+ nfp_net_dev_interrupt_handler,
+ (void *)dev);
+
/*
* The ixgbe PMD driver disables the pcie master on the
* device. The i40e does not...