[dpdk-dev] nfp: fixing bug when copying mac address

Message ID 1471361499-13853-1-git-send-email-alejandro.lucero@netronome.com (mailing list archive)
State Superseded, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Alejandro Lucero Aug. 16, 2016, 3:31 p.m. UTC
  Fixes: defb9a5dd156 ("nfp: introduce driver initialization")

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
 drivers/net/nfp/nfp_net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Ferruh Yigit Sept. 13, 2016, 5:13 p.m. UTC | #1
On 8/16/2016 4:31 PM, Alejandro Lucero wrote:
> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>

check-git-log warning, looks like because of "mac" which should be
uppercase:

Wrong headline lowercase:
        nfp: fixing bug when copying mac address
  

Patch

diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 45d122d..229c8e6 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2421,8 +2421,8 @@  nfp_net_init(struct rte_eth_dev *eth_dev)
 		eth_random_addr(&hw->mac_addr[0]);
 
 	/* Copying mac address to DPDK eth_dev struct */
-	ether_addr_copy(&eth_dev->data->mac_addrs[0],
-			(struct ether_addr *)hw->mac_addr);
+	ether_addr_copy((struct ether_addr *)hw->mac_addr,
+			&eth_dev->data->mac_addrs[0]);
 
 	PMD_INIT_LOG(INFO, "port %d VendorID=0x%x DeviceID=0x%x "
 		     "mac=%02x:%02x:%02x:%02x:%02x:%02x",