Message ID | 1470722518-4733-1-git-send-email-huilongx.xu@intel.com (mailing list archive) |
---|---|
State | Rejected, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id A094837AC; Tue, 9 Aug 2016 08:06:26 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6FE0D3794 for <dev@dpdk.org>; Tue, 9 Aug 2016 08:06:24 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 08 Aug 2016 23:06:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.28,493,1464678000"; d="scan'208"; a="1022136673" Received: from unknown (HELO dpdk-fedora20.icx.intel.com) ([10.239.254.239]) by fmsmga001.fm.intel.com with ESMTP; 08 Aug 2016 23:06:22 -0700 From: "xu,huilong" <huilongx.xu@intel.com> To: dev@dpdk.org Cc: "xu,huilong" <huilongx.xu@intel.com> Date: Tue, 9 Aug 2016 14:01:58 +0800 Message-Id: <1470722518-4733-1-git-send-email-huilongx.xu@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dpdk-dev] [PATCH] mk:fix second compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Xu, HuilongX
Aug. 9, 2016, 6:01 a.m. UTC
when compile different targets on a same environment.
The second compile will failed, because test_resource obj file
can't auto clearn by makfile.
Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
mk/rte.app.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Tue, Aug 09, 2016 at 02:01:58PM +0800, xu,huilong wrote: > when compile different targets on a same environment. > The second compile will failed, because test_resource obj file > can't auto clearn by makfile. > > Signed-off-by: xu,huilong <huilongx.xu@intel.com> > --- > mk/rte.app.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index eb28e11..d23e8b9 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP) > # > .PHONY: clean > clean: _postclean > - $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) > + $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \ > + test_resource.res test_resource_c.o test_resource_c.res.o > This fix looks very specific to the test application, and specific files in that application. Can it be made more generic so that it will work if we add other resource files to the test app without us having to modify the top-level application makefile. Regards, /Bruce
Hi Thomas, Could you give me some comments about this patch. Thanks a lot > -----Original Message----- > From: Xu, HuilongX > Sent: Tuesday, August 09, 2016 2:02 PM > To: dev@dpdk.org > Cc: Xu, HuilongX > Subject: [dpdk-dev][PATCH] mk:fix second compile error > > when compile different targets on a same environment. > The second compile will failed, because test_resource obj file > can't auto clearn by makfile. > > Signed-off-by: xu,huilong <huilongx.xu@intel.com> > --- > mk/rte.app.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index eb28e11..d23e8b9 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP) > # > .PHONY: clean > clean: _postclean > - $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) > + $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) > \ > + test_resource.res test_resource_c.o test_resource_c.res.o > > .PHONY: doclean > doclean: > -- > 1.9.3
Hi Brue, Thanks a lot for your comments. I will send V2 patch. > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, August 09, 2016 4:27 PM > To: Xu, HuilongX > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk:fix second compile error > > On Tue, Aug 09, 2016 at 02:01:58PM +0800, xu,huilong wrote: > > when compile different targets on a same environment. > > The second compile will failed, because test_resource obj file > > can't auto clearn by makfile. > > > > Signed-off-by: xu,huilong <huilongx.xu@intel.com> > > --- > > mk/rte.app.mk | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > > index eb28e11..d23e8b9 100644 > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP) > > # > > .PHONY: clean > > clean: _postclean > > - $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) > > + $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) > \ > > + test_resource.res test_resource_c.o test_resource_c.res.o > > > This fix looks very specific to the test application, and specific files > in > that application. Can it be made more generic so that it will work if we > add > other resource files to the test app without us having to modify the > top-level > application makefile. > > Regards, > /Bruce
2016-08-09 14:01, xu, huilong: > when compile different targets on a same environment. > The second compile will failed, because test_resource obj file > can't auto clearn by makfile. I don't understand the error. Please provide commands and output.
diff --git a/mk/rte.app.mk b/mk/rte.app.mk index eb28e11..d23e8b9 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP) # .PHONY: clean clean: _postclean - $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) + $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \ + test_resource.res test_resource_c.o test_resource_c.res.o .PHONY: doclean doclean: