[dpdk-dev] examples/ip_pipeline: fix wrong values in flow.cfg

Message ID 1469612130-19855-1-git-send-email-sankarx.chokkalingam@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Chokkalingam, SankarX July 27, 2016, 9:35 a.m. UTC
  This configuration is example configuration for flow classification.
This fix changes the offset and mask value to compute the hash correctly.
This fix does not involve code change and do not impact compilation,
build and performance.

Fixes: 93771a569daa ("examples/ip_pipeline: rework flow classification CLI")

Signed-off-by: Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/ip_pipeline/config/flow.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Thomas Monjalon July 28, 2016, 2:58 p.m. UTC | #1
2016-07-27 02:35, Sankar Chokkalingam:
> This configuration is example configuration for flow classification.
> This fix changes the offset and mask value to compute the hash correctly.
> This fix does not involve code change and do not impact compilation,
> build and performance.
> 
> Fixes: 93771a569daa ("examples/ip_pipeline: rework flow classification CLI")
> 
> Signed-off-by: Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks
  

Patch

diff --git a/examples/ip_pipeline/config/flow.cfg b/examples/ip_pipeline/config/flow.cfg
index 6895d39..cec990a 100644
--- a/examples/ip_pipeline/config/flow.cfg
+++ b/examples/ip_pipeline/config/flow.cfg
@@ -64,8 +64,8 @@  pktq_in = RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0
 pktq_out = TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0 SINK0
 n_flows = 65536
 ;key_size = 8                ; QinQ key size
-;key_offset = 270            ; QinQ key offset
-;key_mask = 0000FFF00000FFF0 ; QinQ key mask
+;key_offset = 268            ; QinQ key offset
+;key_mask = 00000FFF00000FFF ; QinQ key mask
 key_size = 16                               ; IPv4 5-tuple key size
 key_offset = 278                            ; IPv4 5-tuple key offset
 key_mask = 00FF0000FFFFFFFFFFFFFFFFFFFFFFFF ; IPv4 5-tuple key mask