[dpdk-dev] net/e1000: fix return value of eth_igb_rx_queue_count()

Message ID 1469625069-49826-1-git-send-email-volkan.atli@argela.com.tr (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Ali Volkan ATLI July 27, 2016, 1:11 p.m. UTC
  Signed-off-by: Ali Volkan ATLI <volkan.atli@argela.com.tr>
---
 drivers/net/e1000/igb_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit Sept. 14, 2016, 1:56 p.m. UTC | #1
On 7/27/2016 2:11 PM, Ali Volkan ATLI wrote:
> Signed-off-by: Ali Volkan ATLI <volkan.atli@argela.com.tr>
> ---

Fixes: 0f6b7c7f7a37 ("igb: use DD bit to count RX available descriptors")

function names not desired in patch subject, what about something like
following:
net/e1000: fix number of available Rx descriptors

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Bruce Richardson Sept. 19, 2016, 4:26 p.m. UTC | #2
On Wed, Sep 14, 2016 at 02:56:47PM +0100, Ferruh Yigit wrote:
> On 7/27/2016 2:11 PM, Ali Volkan ATLI wrote:
> > Signed-off-by: Ali Volkan ATLI <volkan.atli@argela.com.tr>
> > ---
> 
> Fixes: 0f6b7c7f7a37 ("igb: use DD bit to count RX available descriptors")
> 
> function names not desired in patch subject, what about something like
> following:
> net/e1000: fix number of available Rx descriptors
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to rel_16_11 with updated title from Ferruh, and fixes line.

/Bruce
  

Patch

diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index 9d80a0b..c5db727 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -1528,7 +1528,7 @@  eth_igb_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 				desc - rxq->nb_rx_desc]);
 	}
 
-	return 0;
+	return desc;
 }
 
 int