Message ID | 1469550141-24038-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5AABC5596; Tue, 26 Jul 2016 18:22:34 +0200 (CEST) Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 4965D5594 for <dev@dpdk.org>; Tue, 26 Jul 2016 18:22:33 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id f65so180704003wmi.0 for <dev@dpdk.org>; Tue, 26 Jul 2016 09:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=6CFIPXZ4JFLfa8UfGP0AMjnR2aACmd2ynHFewpbifro=; b=qXwrgimyVDTb5hUQ5tJSKyWGLXCJL2HcJiMKFGqaluFq7GZBryz3wRA9GSOlpyQk60 gSvZSGmoBo4tzV8kDeBj2TwyXIDQL6Ebb8OOn0Jo4y2/MrREmgfIhyLaM6W5NZQyvKbu M/f1SndSh9f1cEoAZLaAZQr4dIsrGA175QHRZKB3tKEV9O0a3OK9d32TVNjoop4/FhId RTzOW9LWtPo6JMwCJoAclKAkjKiCbtQNFbiemZSOUc/nhaXB1nof9GQ/Jau0gCvRaVkR F4aY9zNNn4ka0JFmLUXNNuMnk+GbOz9ncBEO/l45BOJbz9rnSdeBGQVXdG/WhKrEnCsw PsMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=6CFIPXZ4JFLfa8UfGP0AMjnR2aACmd2ynHFewpbifro=; b=iscF7+jgnwnIVtIHiPfbxXFd27tOJXNPA+ufc11Ejds+AqEHpuM76EmHnANZ5d+Grx K9Co6EOpXCLh1/rs76FXlep/Z8wkYM8U85tOmmYUaRZ/DkV+/oDV2OweqPf//AQ4LYck o6zGL4CivsJU4SqRF2uvG0qTcWcmN9kjDPeagXTv/jGZmrQJf4jB+siPvQx0/FNF1uOU UxP1h27aWivHR4bw8fE17AEU1WVnhpOKQju+rlaOdSztt2IKzZ1rzAa+TfSaDEYcTjqE ieEDR1jOBdcJwxWylVzD0dhSIGE4c07ARnggCUVkf3SBbVXLsOEzg+4T1JRUIO321dYe 9ioA== X-Gm-Message-State: AEkooutiFB0059pX/B5o2Q51R01RvttkG+eSHVBnvjS527acyjAd+d43oB4JEJKKpqw8XCzQ X-Received: by 10.28.107.144 with SMTP id a16mr27830206wmi.75.1469550152781; Tue, 26 Jul 2016 09:22:32 -0700 (PDT) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id f187sm2498250wmf.15.2016.07.26.09.22.31 for <dev@dpdk.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jul 2016 09:22:32 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: dev@dpdk.org Date: Tue, 26 Jul 2016 18:22:21 +0200 Message-Id: <1469550141-24038-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 Subject: [dpdk-dev] [PATCH] doc: announce renaming of ethdev library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Thomas Monjalon
July 26, 2016, 4:22 p.m. UTC
The right name of ethdev should be dpdk_netdev. However:
1/ We are using rte_ prefix in the code and library names.
2/ The API uses rte_ethdev
That's why 16.11 will just have the rte_ prefix prepended to
the library filename as every other libraries.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
doc/guides/rel_notes/deprecation.rst | 3 +++
1 file changed, 3 insertions(+)
Comments
On Tue, 26 Jul 2016 18:22:21 +0200 Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > The right name of ethdev should be dpdk_netdev. However: > 1/ We are using rte_ prefix in the code and library names. > 2/ The API uses rte_ethdev > That's why 16.11 will just have the rte_ prefix prepended to > the library filename as every other libraries. > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: Jan Viktorin <viktorin@rehivetech.com>
Hi Thomas, just my two cents as Ubuntu DPDK maintainer (and part of the Debian Team that does the same). (Yeah I really could reuse it three times :-) ) It will be a bit of effort to adapt, but should be no rocket-science. I like that eventually the namespace will be cleaner. Just curious, do we already know by looking ahead if ethdev will get an ABI bump anyway? So will the transition be: a) libethdev4 -> librte_ethdev5 b)libethdev4 -> librte_ethdev4 If it is b) would/should one provide a compat symlink then in your Opinion? Anyway, for now I think it is fair to say: Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 27, 2016 at 6:33 PM, Jan Viktorin <viktorin@rehivetech.com> wrote: > On Tue, 26 Jul 2016 18:22:21 +0200 > Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > > > The right name of ethdev should be dpdk_netdev. However: > > 1/ We are using rte_ prefix in the code and library names. > > 2/ The API uses rte_ethdev > > That's why 16.11 will just have the rte_ prefix prepended to > > the library filename as every other libraries. > > > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > > Acked-by: Jan Viktorin <viktorin@rehivetech.com> >
2016-07-28 11:29, Christian Ehrhardt: > Just curious, do we already know by looking ahead if ethdev will get an ABI > bump anyway? > So will the transition be: > a) libethdev4 -> librte_ethdev5 > b)libethdev4 -> librte_ethdev4 > If it is b) would/should one provide a compat symlink then in your Opinion? Good point. We'll make a symlink if the version stay the same. Maybe it will be bumped because of a rework of the hotplug API.
> > The right name of ethdev should be dpdk_netdev. However: > 1/ We are using rte_ prefix in the code and library names. > 2/ The API uses rte_ethdev > That's why 16.11 will just have the rte_ prefix prepended to the > library filename as every other libraries. > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index f502f86..7a55037 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -11,6 +11,9 @@ Deprecation Notices > * The log history is deprecated. > It is voided in 16.07 and will be removed in release 16.11. > > +* The ethdev library file will be renamed from libethdev.* to > +librte_ethdev.* > + in release 16.11 in order to have a more consistent namespace. > + > * The ethdev hotplug API is going to be moved to EAL with a > notification > mechanism added to crypto and ethdev libraries so that hotplug > is > now > available to both of them. This API will be stripped of the > device arguments > -- Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > 2.7.0
> > > The right name of ethdev should be dpdk_netdev. However: > > > 1/ We are using rte_ prefix in the code and library names. > > > 2/ The API uses rte_ethdev > > > That's why 16.11 will just have the rte_ prefix prepended to > > > the library filename as every other libraries. > > > > > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > > > > Acked-by: Jan Viktorin <viktorin@rehivetech.com> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> Applied
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index f502f86..7a55037 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -11,6 +11,9 @@ Deprecation Notices * The log history is deprecated. It is voided in 16.07 and will be removed in release 16.11. +* The ethdev library file will be renamed from libethdev.* to librte_ethdev.* + in release 16.11 in order to have a more consistent namespace. + * The ethdev hotplug API is going to be moved to EAL with a notification mechanism added to crypto and ethdev libraries so that hotplug is now available to both of them. This API will be stripped of the device arguments