diff mbox

[dpdk-dev] test_mempool: remove unused mp_ext var

Message ID 1469101787-7186-1-git-send-email-santosh.shukla@caviumnetworks.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Santosh Shukla July 21, 2016, 11:49 a.m. UTC 
  test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
removing ptr var. Now freeing mp_stack var.

Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
 app/test/test_mempool.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Olivier Matz July 21, 2016, 1:28 p.m. UTC | #1 
Hi Santosh,

On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
> removing ptr var. Now freeing mp_stack var.
> 
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
>  app/test/test_mempool.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
> index 46ad670..3b21cf7 100644
> --- a/app/test/test_mempool.c
> +++ b/app/test/test_mempool.c
> @@ -506,7 +506,6 @@ test_mempool(void)
>  {
>  	struct rte_mempool *mp_cache = NULL;
>  	struct rte_mempool *mp_nocache = NULL;
> -	struct rte_mempool *mp_ext = NULL;
>  	struct rte_mempool *mp_stack = NULL;
>  
>  	rte_atomic32_init(&synchro);
> @@ -605,7 +604,7 @@ test_mempool(void)
>  err:
>  	rte_mempool_free(mp_nocache);
>  	rte_mempool_free(mp_cache);
> -	rte_mempool_free(mp_ext);
> +	rte_mempool_free(mp_stack);
>  	return -1;
>  }
>  
> 

Strange, it seems these modifications were present in latest patch from
David Hunt (v6). Maybe a bad manipulation during the push?

The "Fixes:" line should be added though.

Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thomas Monjalon July 21, 2016, 1:35 p.m. UTC | #2 
2016-07-21 15:28, Olivier Matz:
> Hi Santosh,
> 
> On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> > test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
> > removing ptr var. Now freeing mp_stack var.
> > 
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > ---
> >  app/test/test_mempool.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
> > index 46ad670..3b21cf7 100644
> > --- a/app/test/test_mempool.c
> > +++ b/app/test/test_mempool.c
> > @@ -506,7 +506,6 @@ test_mempool(void)
> >  {
> >  	struct rte_mempool *mp_cache = NULL;
> >  	struct rte_mempool *mp_nocache = NULL;
> > -	struct rte_mempool *mp_ext = NULL;
> >  	struct rte_mempool *mp_stack = NULL;
> >  
> >  	rte_atomic32_init(&synchro);
> > @@ -605,7 +604,7 @@ test_mempool(void)
> >  err:
> >  	rte_mempool_free(mp_nocache);
> >  	rte_mempool_free(mp_cache);
> > -	rte_mempool_free(mp_ext);
> > +	rte_mempool_free(mp_stack);
> >  	return -1;
> >  }
> >  
> > 
> 
> Strange, it seems these modifications were present in latest patch from
> David Hunt (v6). Maybe a bad manipulation during the push?

Yes sorry, it seems to be a wrong manipulation, the v5 was pushed.
This patch seems to fix my error, thanks.

> The "Fixes:" line should be added though.
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thomas Monjalon July 21, 2016, 9:57 p.m. UTC | #3 
2016-07-21 15:35, Thomas Monjalon:
> 2016-07-21 15:28, Olivier Matz:
> > Hi Santosh,
> > 
> > On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> > > test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
> > > removing ptr var. Now freeing mp_stack var.
> > > 
> > > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > 
> > Strange, it seems these modifications were present in latest patch from
> > David Hunt (v6). Maybe a bad manipulation during the push?
> 
> Yes sorry, it seems to be a wrong manipulation, the v5 was pushed.
> This patch seems to fix my error, thanks.
> 
> > The "Fixes:" line should be added though.

Fixes: ea151eb48a04 ("app/test: migrate custom mempool handler to stack handler")

> > Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
index 46ad670..3b21cf7 100644
--- a/app/test/test_mempool.c
+++ b/app/test/test_mempool.c
@@ -506,7 +506,6 @@  test_mempool(void)
 {
 	struct rte_mempool *mp_cache = NULL;
 	struct rte_mempool *mp_nocache = NULL;
-	struct rte_mempool *mp_ext = NULL;
 	struct rte_mempool *mp_stack = NULL;
 
 	rte_atomic32_init(&synchro);
@@ -605,7 +604,7 @@  test_mempool(void)
 err:
 	rte_mempool_free(mp_nocache);
 	rte_mempool_free(mp_cache);
-	rte_mempool_free(mp_ext);
+	rte_mempool_free(mp_stack);
 	return -1;
 }