Message ID | 1468939061-19734-1-git-send-email-zoltan.kiss@schaman.hu (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id EAD7A5477; Tue, 19 Jul 2016 16:38:30 +0200 (CEST) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 9AFBD5398 for <dev@dpdk.org>; Tue, 19 Jul 2016 16:38:30 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id 33so1479286lfw.3 for <dev@dpdk.org>; Tue, 19 Jul 2016 07:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schaman-hu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=LIdQV0EpfaUb7CofHEuKlHadt0qWoQEWIyAgIVZrsaQ=; b=Rp1PAo5IQ616b/iuorxDQ4U1opmNV/Hch19eyxYNnfKgo49dOx19o/SktDmp7fBHB1 wm5EHHO3jfu+R9b8L+UkzOMfd1ri/YCMTdpiiURdeb5+liVTgbiLaw+ezezU09jLmtS8 W19LaHJswMigKEY+jkYjA3oajPW9B6/mttUxUbnP44rzO1as+anlRJkF3Dfv0sL7YT9c sljQI03LT3Ulx0CRcxrc+KQBOuCEctaya/dXXqFDxoWS/M1rOBUNzKE+rotRqO9t8FFO ssmUIKN51+RfhgPyfpAc4YJVT0k40B5eH6vyip5oIsJA4QNxKDjKUrQb/C9pCfaNw28N Jaag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LIdQV0EpfaUb7CofHEuKlHadt0qWoQEWIyAgIVZrsaQ=; b=SkNzarXggdIKqWXbvQ+ecccFvI6P5BhISzSFvM6n9NcWD7a3QvLTfT0FFv9jB+NtDZ BIdUR6iGzETec2FEe9mJH1QWW9/LwE9dKRoOSNmg1giwoN8nUgIesqq1VwCuXvDYhYB5 4TEApbhNddRwqrdCXORvzr3+9swLKW8E1KIrIjMD+L46FqEOkVOpBN7B4XUGo5cOy4nv oP9Pyd1Oo1zC7Esv1KVd6PJre6eMi5QF/2pN0HEa5V5o6mG9aHz76n/C+INlIzQQDCGe dF4v7eUFKDIhMXMANLu1XkdH2qMHBvKW+oq+oPA+6KNmO2UJOOBkgcBzhKlufOMNyBh5 bvpg== X-Gm-Message-State: ALyK8tII8bw0bjU5vMHqLLvtBATa4MyN2p/8ZKQTma6sVEONRd4b1ZDIYLqTaGRTu+b1rg== X-Received: by 10.25.43.144 with SMTP id r138mr18307380lfr.112.1468939110040; Tue, 19 Jul 2016 07:38:30 -0700 (PDT) Received: from localhost.localdomain ([195.11.233.227]) by smtp.googlemail.com with ESMTPSA id h191sm5758935lfh.0.2016.07.19.07.38.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jul 2016 07:38:29 -0700 (PDT) From: Zoltan Kiss <zoltan.kiss@schaman.hu> To: dev@dpdk.org Cc: David Hunt <david.hunt@intel.com>, olivier.matz@6wind.com Date: Tue, 19 Jul 2016 15:37:40 +0100 Message-Id: <1468939061-19734-1-git-send-email-zoltan.kiss@schaman.hu> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [PATCH] mempool: fix lack of free() registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Zoltan Kiss
July 19, 2016, 2:37 p.m. UTC
The new mempool handler interface forgets to register the free() function
of the ops. Introduced in this patch:
449c49b9 mempool: support handler operations
Signed-off-by: Zoltan Kiss <zoltan.kiss@schaman.hu>
---
lib/librte_mempool/rte_mempool_ops.c | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Zoltan, I ran ./scripts/check-git-log.sh on your patch, showing some minor styling issues: On 07/19/2016 04:37 PM, Zoltan Kiss wrote: > [PATCH] mempool: fix lack of free() registration "()" should be removed > The new mempool handler interface forgets to register the free() function > of the ops. Introduced in this patch: > > 449c49b9 mempool: support handler operations The format should be: Fixes: 449c49b93a6b ("mempool: support handler operations") > > Signed-off-by: Zoltan Kiss <zoltan.kiss@schaman.hu> > --- > lib/librte_mempool/rte_mempool_ops.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c > index fd0b64c..5f24de2 100644 > --- a/lib/librte_mempool/rte_mempool_ops.c > +++ b/lib/librte_mempool/rte_mempool_ops.c > @@ -81,6 +81,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h) > ops = &rte_mempool_ops_table.ops[ops_index]; > snprintf(ops->name, sizeof(ops->name), "%s", h->name); > ops->alloc = h->alloc; > + ops->free = h->free; > ops->enqueue = h->enqueue; > ops->dequeue = h->dequeue; > ops->get_count = h->get_count; > Apart from that: Acked-by: Olivier Matz <olivier.matz@6wind.com> +CC Thomas, I think it should be included in 16.07. Thanks!
On 19/07/16 16:26, Olivier Matz wrote: > Hi Zoltan, > > I ran ./scripts/check-git-log.sh on your patch, showing some minor > styling issues: Thanks, do you want me to resend it, or could Thomas fix them upon commiting? > > On 07/19/2016 04:37 PM, Zoltan Kiss wrote: >> [PATCH] mempool: fix lack of free() registration > > "()" should be removed > >> The new mempool handler interface forgets to register the free() function >> of the ops. Introduced in this patch: >> >> 449c49b9 mempool: support handler operations > > The format should be: > Fixes: 449c49b93a6b ("mempool: support handler operations") > > >> >> Signed-off-by: Zoltan Kiss <zoltan.kiss@schaman.hu> >> --- >> lib/librte_mempool/rte_mempool_ops.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c >> index fd0b64c..5f24de2 100644 >> --- a/lib/librte_mempool/rte_mempool_ops.c >> +++ b/lib/librte_mempool/rte_mempool_ops.c >> @@ -81,6 +81,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h) >> ops = &rte_mempool_ops_table.ops[ops_index]; >> snprintf(ops->name, sizeof(ops->name), "%s", h->name); >> ops->alloc = h->alloc; >> + ops->free = h->free; >> ops->enqueue = h->enqueue; >> ops->dequeue = h->dequeue; >> ops->get_count = h->get_count; >> > > Apart from that: > Acked-by: Olivier Matz <olivier.matz@6wind.com> > > +CC Thomas, I think it should be included in 16.07. > > Thanks! >
diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c index fd0b64c..5f24de2 100644 --- a/lib/librte_mempool/rte_mempool_ops.c +++ b/lib/librte_mempool/rte_mempool_ops.c @@ -81,6 +81,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h) ops = &rte_mempool_ops_table.ops[ops_index]; snprintf(ops->name, sizeof(ops->name), "%s", h->name); ops->alloc = h->alloc; + ops->free = h->free; ops->enqueue = h->enqueue; ops->dequeue = h->dequeue; ops->get_count = h->get_count;