[dpdk-dev] doc: deprecate vhost-cuse

Message ID 1468585713-28557-1-git-send-email-yuanhan.liu@linux.intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Yuanhan Liu July 15, 2016, 12:28 p.m. UTC
  Vhost-cuse was invented before vhost-user exist. The both are actually
doing the same thing: a vhost-net implementation in user space. But they
are not exactly the same thing.

Firstly, vhost-cuse is harder for use; no one seems to care it, either.
Furthermore, since v2.1, a large majority of development effort has gone
to vhost-user. For example, we extended the vhost-user spec to add the
multiple queue support. We also added the vhost-user live migration at
v16.04 and the latest one, vhost-user reconnect that allows vhost app
restart without restarting the guest. Both of them are very important
features for product usage and none of them works for vhost-cuse.

You now see that the difference between vhost-user and vhost-cuse is
big (and will be bigger and bigger as time moves forward), that you
should never use vhost-cuse, that we should drop it completely.

The remove would also result to a much cleaner code base, allowing us
to do all kinds of extending easier.

So here to mark vhost-cuse as deprecated in this release and will be
removed in the next release (v16.11).

Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Loftus, Ciara July 21, 2016, 11:07 a.m. UTC | #1
> Subject: [dpdk-dev] [PATCH] doc: deprecate vhost-cuse
> 
> Vhost-cuse was invented before vhost-user exist. The both are actually
> doing the same thing: a vhost-net implementation in user space. But they
> are not exactly the same thing.
> 
> Firstly, vhost-cuse is harder for use; no one seems to care it, either.
> Furthermore, since v2.1, a large majority of development effort has gone
> to vhost-user. For example, we extended the vhost-user spec to add the
> multiple queue support. We also added the vhost-user live migration at
> v16.04 and the latest one, vhost-user reconnect that allows vhost app
> restart without restarting the guest. Both of them are very important
> features for product usage and none of them works for vhost-cuse.
> 
> You now see that the difference between vhost-user and vhost-cuse is
> big (and will be bigger and bigger as time moves forward), that you
> should never use vhost-cuse, that we should drop it completely.
> 
> The remove would also result to a much cleaner code base, allowing us
> to do all kinds of extending easier.
> 
> So here to mark vhost-cuse as deprecated in this release and will be
> removed in the next release (v16.11).
> 
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f502f86..ee99558 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -41,3 +41,7 @@ Deprecation Notices
>  * The mempool functions for single/multi producer/consumer are
> deprecated and
>    will be removed in 16.11.
>    It is replaced by rte_mempool_generic_get/put functions.
> +
> +* The vhost-cuse will be removed in 16.11. Since v2.1, a large majority of
> +  development effort has gone to vhost-user, such as multiple-queue, live
> +  migration, reconnect etc. Therefore, vhost-user should be used instead.
> --
> 1.9.0

Acked-by: Ciara Loftus <ciara.loftus@intel.com>
  
Thomas Monjalon July 27, 2016, 8:31 a.m. UTC | #2
> > Vhost-cuse was invented before vhost-user exist. The both are actually
> > doing the same thing: a vhost-net implementation in user space. But they
> > are not exactly the same thing.
> > 
> > Firstly, vhost-cuse is harder for use; no one seems to care it, either.
> > Furthermore, since v2.1, a large majority of development effort has gone
> > to vhost-user. For example, we extended the vhost-user spec to add the
> > multiple queue support. We also added the vhost-user live migration at
> > v16.04 and the latest one, vhost-user reconnect that allows vhost app
> > restart without restarting the guest. Both of them are very important
> > features for product usage and none of them works for vhost-cuse.
> > 
> > You now see that the difference between vhost-user and vhost-cuse is
> > big (and will be bigger and bigger as time moves forward), that you
> > should never use vhost-cuse, that we should drop it completely.
> > 
> > The remove would also result to a much cleaner code base, allowing us
> > to do all kinds of extending easier.
> > 
> > So here to mark vhost-cuse as deprecated in this release and will be
> > removed in the next release (v16.11).
> > 
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> 
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
  
Rich Lane July 27, 2016, 3:57 p.m. UTC | #3
On Wed, Jul 27, 2016 at 1:31 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> > > Vhost-cuse was invented before vhost-user exist. The both are actually
> > > doing the same thing: a vhost-net implementation in user space. But
> they
> > > are not exactly the same thing.
> > >
> > > Firstly, vhost-cuse is harder for use; no one seems to care it, either.
> > > Furthermore, since v2.1, a large majority of development effort has
> gone
> > > to vhost-user. For example, we extended the vhost-user spec to add the
> > > multiple queue support. We also added the vhost-user live migration at
> > > v16.04 and the latest one, vhost-user reconnect that allows vhost app
> > > restart without restarting the guest. Both of them are very important
> > > features for product usage and none of them works for vhost-cuse.
> > >
> > > You now see that the difference between vhost-user and vhost-cuse is
> > > big (and will be bigger and bigger as time moves forward), that you
> > > should never use vhost-cuse, that we should drop it completely.
> > >
> > > The remove would also result to a much cleaner code base, allowing us
> > > to do all kinds of extending easier.
> > >
> > > So here to mark vhost-cuse as deprecated in this release and will be
> > > removed in the next release (v16.11).
> > >
> > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >
> > Acked-by: Ciara Loftus <ciara.loftus@intel.com>
>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>

Acked-by: Rich Lane <rich.lane@bigswitch.com>
  
Jan Viktorin July 27, 2016, 6:59 p.m. UTC | #4
On Fri, 15 Jul 2016 20:28:33 +0800
Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote:

> Vhost-cuse was invented before vhost-user exist. The both are actually
> doing the same thing: a vhost-net implementation in user space. But they
> are not exactly the same thing.
> 
> Firstly, vhost-cuse is harder for use; no one seems to care it, either.
> Furthermore, since v2.1, a large majority of development effort has gone
> to vhost-user. For example, we extended the vhost-user spec to add the
> multiple queue support. We also added the vhost-user live migration at
> v16.04 and the latest one, vhost-user reconnect that allows vhost app
> restart without restarting the guest. Both of them are very important
> features for product usage and none of them works for vhost-cuse.
> 
> You now see that the difference between vhost-user and vhost-cuse is
> big (and will be bigger and bigger as time moves forward), that you
> should never use vhost-cuse, that we should drop it completely.
> 
> The remove would also result to a much cleaner code base, allowing us
> to do all kinds of extending easier.
> 
> So here to mark vhost-cuse as deprecated in this release and will be
> removed in the next release (v16.11).
> 
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> Acked-by: Rich Lane <rich.lane@bigswitch.com>

Acked-by: Jan Viktorin <viktorin@rehivetech.com>
  
Christian Ehrhardt July 28, 2016, 9:10 a.m. UTC | #5
Hi Thomas,
just my two cents as Ubuntu DPDK maintainer (and part of the Debian Team
that does the same).

We never used vhost-cuse in any of our exampled, documentations or tests
(It seems we started "late enough").

So again I think it is a good change to drop rather unmaintained parts to
make the rest more stable:
Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

On Wed, Jul 27, 2016 at 8:59 PM, Jan Viktorin <viktorin@rehivetech.com>
wrote:

> On Fri, 15 Jul 2016 20:28:33 +0800
> Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote:
>
> > Vhost-cuse was invented before vhost-user exist. The both are actually
> > doing the same thing: a vhost-net implementation in user space. But they
> > are not exactly the same thing.
> >
> > Firstly, vhost-cuse is harder for use; no one seems to care it, either.
> > Furthermore, since v2.1, a large majority of development effort has gone
> > to vhost-user. For example, we extended the vhost-user spec to add the
> > multiple queue support. We also added the vhost-user live migration at
> > v16.04 and the latest one, vhost-user reconnect that allows vhost app
> > restart without restarting the guest. Both of them are very important
> > features for product usage and none of them works for vhost-cuse.
> >
> > You now see that the difference between vhost-user and vhost-cuse is
> > big (and will be bigger and bigger as time moves forward), that you
> > should never use vhost-cuse, that we should drop it completely.
> >
> > The remove would also result to a much cleaner code base, allowing us
> > to do all kinds of extending easier.
> >
> > So here to mark vhost-cuse as deprecated in this release and will be
> > removed in the next release (v16.11).
> >
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Acked-by: Rich Lane <rich.lane@bigswitch.com>
>
> Acked-by: Jan Viktorin <viktorin@rehivetech.com>
>
  
Thomas Monjalon July 28, 2016, 6:12 p.m. UTC | #6
> > > Vhost-cuse was invented before vhost-user exist. The both are actually
> > > doing the same thing: a vhost-net implementation in user space. But they
> > > are not exactly the same thing.
> > >
> > > Firstly, vhost-cuse is harder for use; no one seems to care it, either.
> > > Furthermore, since v2.1, a large majority of development effort has gone
> > > to vhost-user. For example, we extended the vhost-user spec to add the
> > > multiple queue support. We also added the vhost-user live migration at
> > > v16.04 and the latest one, vhost-user reconnect that allows vhost app
> > > restart without restarting the guest. Both of them are very important
> > > features for product usage and none of them works for vhost-cuse.
> > >
> > > You now see that the difference between vhost-user and vhost-cuse is
> > > big (and will be bigger and bigger as time moves forward), that you
> > > should never use vhost-cuse, that we should drop it completely.
> > >
> > > The remove would also result to a much cleaner code base, allowing us
> > > to do all kinds of extending easier.
> > >
> > > So here to mark vhost-cuse as deprecated in this release and will be
> > > removed in the next release (v16.11).
> > >
> > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > > Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > > Acked-by: Rich Lane <rich.lane@bigswitch.com>
> > Acked-by: Jan Viktorin <viktorin@rehivetech.com>
> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Applied, thanks
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index f502f86..ee99558 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -41,3 +41,7 @@  Deprecation Notices
 * The mempool functions for single/multi producer/consumer are deprecated and
   will be removed in 16.11.
   It is replaced by rte_mempool_generic_get/put functions.
+
+* The vhost-cuse will be removed in 16.11. Since v2.1, a large majority of
+  development effort has gone to vhost-user, such as multiple-queue, live
+  migration, reconnect etc. Therefore, vhost-user should be used instead.