diff mbox

[dpdk-dev] examples/vhost: fix failure without hints

Message ID 1467363031-106737-1-git-send-email-jianfeng.tan@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Yuanhan Liu
Headers

Commit Message

Jianfeng Tan July 1, 2016, 8:50 a.m. UTC 
  When the specified cores and memory lie on different numa socket with
physical NIC, vhost fails to set up rx queue, and exits without any
hints. This could leads to confusion of users.

This patch fixes it by adding some error messages when calling ether
APIs returns errors.

Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")

Reported-by: Yulong Pei <yulong.pei@intel.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 examples/vhost/main.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

Comments

Yuanhan Liu July 4, 2016, 3 a.m. UTC | #1 
On Fri, Jul 01, 2016 at 08:50:31AM +0000, Jianfeng Tan wrote:
> When the specified cores and memory lie on different numa socket with
> physical NIC, vhost fails to set up rx queue, and exits without any
> hints. This could leads to confusion of users.
> 
> This patch fixes it by adding some error messages when calling ether
> APIs returns errors.
> 
> Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")

I will not call it a "fix", instead, it's an "enhancement" to me.

> Reported-by: Yulong Pei <yulong.pei@intel.com>

And since it's not a bug, it might be "Suggested-by: ...".

	--yliu
Yuanhan Liu July 11, 2016, 2:07 a.m. UTC | #2 
On Mon, Jul 04, 2016 at 11:00:13AM +0800, Yuanhan Liu wrote:
> On Fri, Jul 01, 2016 at 08:50:31AM +0000, Jianfeng Tan wrote:
> > When the specified cores and memory lie on different numa socket with
> > physical NIC, vhost fails to set up rx queue, and exits without any
> > hints. This could leads to confusion of users.
> > 
> > This patch fixes it by adding some error messages when calling ether
> > APIs returns errors.
> > 
> > Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
> 
> I will not call it a "fix", instead, it's an "enhancement" to me.
> 
> > Reported-by: Yulong Pei <yulong.pei@intel.com>
> 
> And since it's not a bug, it might be "Suggested-by: ...".

Applied to dpdk-next-virtio, with some commit log rewords.

Thanks.

	--yliu
diff mbox

Patch

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 3aff2cc..3b98f42 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -332,8 +332,11 @@  port_init(uint8_t port)
 	rx_rings = (uint16_t)dev_info.max_rx_queues;
 	/* Configure ethernet device. */
 	retval = rte_eth_dev_configure(port, rx_rings, tx_rings, &port_conf);
-	if (retval != 0)
+	if (retval != 0) {
+		RTE_LOG(ERR, VHOST_PORT, "Failed to configure port %u: %s.\n",
+			port, strerror(-retval));
 		return retval;
+	}
 
 	/* Setup the queues. */
 	for (q = 0; q < rx_rings; q ++) {
@@ -341,21 +344,30 @@  port_init(uint8_t port)
 						rte_eth_dev_socket_id(port),
 						rxconf,
 						mbuf_pool);
-		if (retval < 0)
+		if (retval < 0) {
+			RTE_LOG(ERR, VHOST_PORT,
+				"Failed to setup rx queue %u of port %u: %s.\n",
+				q, port, strerror(-retval));
 			return retval;
+		}
 	}
 	for (q = 0; q < tx_rings; q ++) {
 		retval = rte_eth_tx_queue_setup(port, q, tx_ring_size,
 						rte_eth_dev_socket_id(port),
 						txconf);
-		if (retval < 0)
+		if (retval < 0) {
+			RTE_LOG(ERR, VHOST_PORT,
+				"Failed to setup tx queue %u of port %u: %s.\n",
+				q, port, strerror(-retval));
 			return retval;
+		}
 	}
 
 	/* Start the device. */
 	retval  = rte_eth_dev_start(port);
 	if (retval < 0) {
-		RTE_LOG(ERR, VHOST_DATA, "Failed to start the device.\n");
+		RTE_LOG(ERR, VHOST_PORT, "Failed to start port %u: %s\n",
+			port, strerror(-retval));
 		return retval;
 	}