diff mbox

[dpdk-dev] scripts: relax line length check for fixed commit

Message ID 1466721858-3432-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Thomas Monjalon June 23, 2016, 10:44 p.m. UTC 
  It is better to keep the line "Fixes:" longer than 75 characters
than splitting.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/check-git-log.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson June 24, 2016, 9:30 a.m. UTC | #1 
On Fri, Jun 24, 2016 at 12:44:18AM +0200, Thomas Monjalon wrote:
> It is better to keep the line "Fixes:" longer than 75 characters
> than splitting.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Definite +1

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Wiles, Keith June 25, 2016, 1:59 p.m. UTC | #2 
On 6/24/16, 4:30 AM, "dev on behalf of Bruce Richardson" <dev-bounces@dpdk.org on behalf of bruce.richardson@intel.com> wrote:

>On Fri, Jun 24, 2016 at 12:44:18AM +0200, Thomas Monjalon wrote:

>> It is better to keep the line "Fixes:" longer than 75 characters

>> than splitting.

>> 

>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

>

>Definite +1


Yes, +2 for me.

>

>Acked-by: Bruce Richardson <bruce.richardson@intel.com>

>

>
Thomas Monjalon June 27, 2016, 2:54 p.m. UTC | #3 
2016-06-25 13:59, Wiles, Keith:
> On 6/24/16, 4:30 AM, "dev on behalf of Bruce Richardson" <dev-bounces@dpdk.org on behalf of bruce.richardson@intel.com> wrote:
> 
> >On Fri, Jun 24, 2016 at 12:44:18AM +0200, Thomas Monjalon wrote:
> >> It is better to keep the line "Fixes:" longer than 75 characters
> >> than splitting.
> >> 
> >> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >
> >Definite +1
> 
> Yes, +2 for me.

Applied
diff mbox

Patch

diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 153f378..4253d14 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -111,7 +111,7 @@  bad=$(echo "$headlines" | awk 'length>60 {print}' | sed 's,^,\t,')
 [ -z "$bad" ] || printf "Headline too long:\n$bad\n"
 
 # check body lines length (75 max)
-bad=$(echo "$bodylines" | awk 'length>75 {print}' | sed 's,^,\t,')
+bad=$(echo "$bodylines" | grep -v '^Fixes:' | awk 'length>75 {print}' | sed 's,^,\t,')
 [ -z "$bad" ] || printf "Line too long:\n$bad\n"
 
 # check tags spelling