[dpdk-dev] app/test: fix for icc compilation error

Message ID 1466612035-28013-1-git-send-email-deepak.k.jain@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Deepak Kumar JAIN June 22, 2016, 4:13 p.m. UTC
  Icc complains about variable may be used without setting.

Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test)

Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
---
 app/test/test_cryptodev_perf.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
  

Comments

Griffin, John June 22, 2016, 4:22 p.m. UTC | #1
On 22/06/16 17:13, Deepak Kumar Jain wrote:
> Icc complains about variable may be used without setting.
>
> Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test)
>
> Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Acked-by: John Griffin <john.griffin@intel.com>
  
Thomas Monjalon June 27, 2016, 10:32 a.m. UTC | #2
> > Icc complains about variable may be used without setting.
> >
> > Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test)
> >
> > Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
> Acked-by: John Griffin <john.griffin@intel.com>

Applied, thanks
  

Patch

diff --git a/app/test/test_cryptodev_perf.c b/app/test/test_cryptodev_perf.c
index e1adc99..e484cbb 100644
--- a/app/test/test_cryptodev_perf.c
+++ b/app/test/test_cryptodev_perf.c
@@ -2458,18 +2458,17 @@  test_perf_aes_sha(uint8_t dev_id, uint16_t queue_id,
 
 	/* Generate a burst of crypto operations */
 	for (i = 0; i < (pparams->burst_size * NUM_MBUF_SETS); i++) {
-		struct rte_mbuf *m = test_perf_create_pktmbuf(
+		mbufs[i] = test_perf_create_pktmbuf(
 				ts_params->mbuf_mp,
 				pparams->buf_size);
 
-		if (m == NULL) {
+		if (mbufs[i] == NULL) {
 			printf("\nFailed to get mbuf - freeing the rest.\n");
 			for (k = 0; k < i; k++)
 				rte_pktmbuf_free(mbufs[k]);
 			return -1;
 		}
 
-		mbufs[i] = m;
 	}
 
 
@@ -2587,18 +2586,17 @@  test_perf_snow3g(uint8_t dev_id, uint16_t queue_id,
 
 	/* Generate a burst of crypto operations */
 	for (i = 0; i < (pparams->burst_size * NUM_MBUF_SETS); i++) {
-		struct rte_mbuf *m = test_perf_create_pktmbuf(
+		mbufs[i] = test_perf_create_pktmbuf(
 				ts_params->mbuf_mp,
 				pparams->buf_size);
 
-		if (m == NULL) {
+		if (mbufs[i] == NULL) {
 			printf("\nFailed to get mbuf - freeing the rest.\n");
 			for (k = 0; k < i; k++)
 				rte_pktmbuf_free(mbufs[k]);
 			return -1;
 		}
 
-		mbufs[i] = m;
 	}
 
 	tsc_start = rte_rdtsc_precise();