[dpdk-dev] mk: mute build of test resources

Message ID 1466114469-22789-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Thomas Monjalon June 16, 2016, 10:01 p.m. UTC
  The objcopy and tar commands were printed even in quiet mode.
They are now replaced by a simple line and still visible in verbose mode.

Fixes: ab64f5df8004 ("app/test: support resources externally linked")
Fixes: 66819e6c11d8 ("app/test: support resources archived by tar")

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 app/test/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
  

Comments

Bruce Richardson June 17, 2016, 9:55 a.m. UTC | #1
On Fri, Jun 17, 2016 at 12:01:09AM +0200, Thomas Monjalon wrote:
> The objcopy and tar commands were printed even in quiet mode.
> They are now replaced by a simple line and still visible in verbose mode.
> 
> Fixes: ab64f5df8004 ("app/test: support resources externally linked")
> Fixes: 66819e6c11d8 ("app/test: support resources archived by tar")
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  
Thomas Monjalon June 17, 2016, 10:10 a.m. UTC | #2
> > The objcopy and tar commands were printed even in quiet mode.
> > They are now replaced by a simple line and still visible in verbose mode.
> > 
> > Fixes: ab64f5df8004 ("app/test: support resources externally linked")
> > Fixes: 66819e6c11d8 ("app/test: support resources archived by tar")
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied
  

Patch

diff --git a/app/test/Makefile b/app/test/Makefile
index 053f3a2..5e3ebdc 100644
--- a/app/test/Makefile
+++ b/app/test/Makefile
@@ -42,7 +42,8 @@  ifeq ($(CONFIG_RTE_APP_TEST),y)
 define linked_resource
 SRCS-y += $(1).res.o
 $(1).res.o: $(2)
-	$(OBJCOPY) -I binary -B $(RTE_OBJCOPY_ARCH) -O $(RTE_OBJCOPY_TARGET) \
+	@  echo '  MKRES $$@'
+	$Q $(OBJCOPY) -I binary -B $(RTE_OBJCOPY_ARCH) -O $(RTE_OBJCOPY_TARGET) \
 		--rename-section                                         \
 			.data=.rodata,alloc,load,data,contents,readonly  \
 		--redefine-sym _binary__dev_stdin_start=beg_$(1)         \
@@ -54,7 +55,8 @@  endef
 ifeq ($(CONFIG_RTE_APP_TEST_RESOURCE_TAR),y)
 define linked_tar_resource
 $(1).tar: $(2)
-	tar -C $$(dir $$<) -cf $$@ $$(notdir $$<)
+	@  echo '  TAR $$@'
+	$Q tar -C $$(dir $$<) -cf $$@ $$(notdir $$<)
 $(call linked_resource,$(1),$(1).tar)
 endef
 else # ! CONFIG_RTE_APP_TEST_RESOURCE_TAR