diff mbox

[dpdk-dev,v1] change log level for check when add port in blacklist

Message ID 1464662412-2695-1-git-send-email-huilongx.xu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Xu, HuilongX May 31, 2016, 2:40 a.m. UTC 
  maybe we should change log level, when add port in blacklist,for check it easy.
and it not influence performance and function

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 lib/librte_eal/common/eal_common_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon May 31, 2016, 6:34 a.m. UTC | #1 
2016-05-31 10:40, xu, huilong:
> maybe we should change log level, when add port in blacklist,for check it easy.
> and it not influence performance and function

Please, could you show an example of the device init logs at INFO level
before and after this patch?
Thanks
Wenzhuo Lu June 7, 2016, 1:47 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Tuesday, May 31, 2016 10:40 AM
> To: dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; Xu, HuilongX
> Subject: [dpdk-dev] [PATCH v1] change log level for check when add port in
> blacklist
> 
> maybe we should change log level, when add port in blacklist,for check it easy.
> and it not influence performance and function
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Considering the usability, prefer to show the log to users.
Thomas Monjalon June 30, 2016, 12:02 p.m. UTC | #3 
2016-06-07 01:47, Lu, Wenzhuo:
> > maybe we should change log level, when add port in blacklist,for check it easy.
> > and it not influence performance and function
> > 
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Considering the usability, prefer to show the log to users.

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 3cae4cb..154bac5 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -172,7 +172,7 @@  rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d
 		/* no initialization when blacklisted, return without error */
 		if (dev->devargs != NULL &&
 			dev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {
-			RTE_LOG(DEBUG, EAL, "  Device is blacklisted, not initializing\n");
+			RTE_LOG(INFO, EAL, "  Device is blacklisted, not initializing\n");
 			return 1;
 		}