diff mbox

[dpdk-dev] enic: negative array index write

Message ID 1464353766-2404-1-git-send-email-slawomirx.mrozowicz@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Slawomir Mrozowicz May 27, 2016, 12:56 p.m. UTC 
  Negative array index write using variable pos as an index to array enic->fdir.nodes.
Fixed by add array index check.

Fixes: fefed3d1e62c ("enic: new driver")
Coverity ID 13270

Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
---
 drivers/net/enic/enic_clsf.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Ferruh Yigit June 20, 2016, 2:35 p.m. UTC | #1 
On 5/27/2016 1:56 PM, Slawomir Mrozowicz wrote:
> Negative array index write using variable pos as an index to array enic->fdir.nodes.
> Fixed by add array index check.
> 
> Fixes: fefed3d1e62c ("enic: new driver")
> Coverity ID 13270
> 
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> ---

Hi John, Nelson,

Any comment to this patch?

Thanks,
ferruh
diff mbox

Patch

diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index edb56e1..6b1489d 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -213,6 +213,12 @@  int enic_fdir_add_fltr(struct enic *enic, struct rte_eth_fdir_filter *params)
 	}
 
 	pos = rte_hash_add_key(enic->fdir.hash, params);
+	if (pos < 0 || pos >= ENICPMD_FDIR_MAX) {
+		dev_err(enic, "Add hash key failed\n");
+		enic->fdir.stats.f_add++;
+		return -EINVAL;
+	}
+
 	enic->fdir.nodes[pos] = key;
 	return 0;
 }