[dpdk-dev,v2] qede: fix build issue in the cross-compiling mode

Message ID 1464243175-4170-1-git-send-email-jerin.jacob@caviumnetworks.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Jerin Jacob May 26, 2016, 6:12 a.m. UTC
  In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
instead of just gcc

Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
v1..v2
Use CONFIG_RTE_TOOLCHAIN_GCC instead of regular expression in filter
---
 drivers/net/qede/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Thomas Monjalon May 26, 2016, 6:36 a.m. UTC | #1
2016-05-26 11:42, Jerin Jacob:
> In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> instead of just gcc
> 
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

We should do the same change for clang and icc. Please check
	git grep '(CC)'
  

Patch

diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index c9b3b1c..d4b1e28 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -47,7 +47,7 @@  endif
 endif
 endif
 
-ifneq (,$(filter gcc gcc48,$(CC)))
+ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
 CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
 CFLAGS_BASE_DRIVER += -Wno-missing-declarations
 CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized