Message ID | 1462379876-21901-1-git-send-email-bruce.richardson@intel.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id EADE05583; Wed, 4 May 2016 18:47:36 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2514C388F for <dev@dpdk.org>; Wed, 4 May 2016 18:47:34 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 04 May 2016 09:38:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,578,1455004800"; d="scan'208";a="972594023" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga002.fm.intel.com with ESMTP; 04 May 2016 09:38:05 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u44Gc4Ln025536; Wed, 4 May 2016 17:38:04 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id u44Gc4Jn022005; Wed, 4 May 2016 17:38:04 +0100 Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id u44Gc4Ix022001; Wed, 4 May 2016 17:38:04 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: thomas.monjalon@6wind.com, Bruce Richardson <bruce.richardson@intel.com> Date: Wed, 4 May 2016 17:37:56 +0100 Message-Id: <1462379876-21901-1-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] eal: add missing include to debug header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Bruce Richardson
May 4, 2016, 4:37 p.m. UTC
The header file rte_debug.h makes use of the "unlikely" macro which
means it should include the rte_branch_prediction.h header file.
Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/librte_eal/common/include/rte_debug.h | 1 +
1 file changed, 1 insertion(+)
Comments
On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote: > The header file rte_debug.h makes use of the "unlikely" macro which > means it should include the rte_branch_prediction.h header file. > > Fixes: 50705e8e3cdd ("eal: add assert macro for debug") > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > --- > lib/librte_eal/common/include/rte_debug.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h > index 9260eda..cab6fb4 100644 > --- a/lib/librte_eal/common/include/rte_debug.h > +++ b/lib/librte_eal/common/include/rte_debug.h > @@ -44,6 +44,7 @@ > */ > > #include "rte_log.h" > +#include "rte_branch_prediction.h" > > #ifdef __cplusplus > extern "C" { Ping on this patch - any comments or concerns? It's a fairly trivial fix that prevents issues with testing some other patches on the mainline. Regards, /Bruce
On 5/5/2016 1:59 PM, Bruce Richardson wrote: > On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote: >> The header file rte_debug.h makes use of the "unlikely" macro which >> means it should include the rte_branch_prediction.h header file. >> >> Fixes: 50705e8e3cdd ("eal: add assert macro for debug") >> >> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> >> --- >> lib/librte_eal/common/include/rte_debug.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h >> index 9260eda..cab6fb4 100644 >> --- a/lib/librte_eal/common/include/rte_debug.h >> +++ b/lib/librte_eal/common/include/rte_debug.h >> @@ -44,6 +44,7 @@ >> */ >> >> #include "rte_log.h" >> +#include "rte_branch_prediction.h" >> >> #ifdef __cplusplus >> extern "C" { > > Ping on this patch - any comments or concerns? > It's a fairly trivial fix that prevents issues with testing some other patches > on the mainline. > Tested on top of David Marchand's 12123-12139 patchset. Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
2016-05-05 17:07, Ferruh Yigit: > On 5/5/2016 1:59 PM, Bruce Richardson wrote: > > On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote: > >> The header file rte_debug.h makes use of the "unlikely" macro which > >> means it should include the rte_branch_prediction.h header file. > >> > >> Fixes: 50705e8e3cdd ("eal: add assert macro for debug") > >> > >> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > > > Ping on this patch - any comments or concerns? > > It's a fairly trivial fix that prevents issues with testing some other patches > > on the mainline. > > > > Tested on top of David Marchand's 12123-12139 patchset. > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied, thanks Sorry for the delay, I was gardening today :)
diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h index 9260eda..cab6fb4 100644 --- a/lib/librte_eal/common/include/rte_debug.h +++ b/lib/librte_eal/common/include/rte_debug.h @@ -44,6 +44,7 @@ */ #include "rte_log.h" +#include "rte_branch_prediction.h" #ifdef __cplusplus extern "C" {