[dpdk-dev] eal: add missing include to debug header

Message ID 1462379876-21901-1-git-send-email-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Bruce Richardson May 4, 2016, 4:37 p.m. UTC
  The header file rte_debug.h makes use of the "unlikely" macro which
means it should include the rte_branch_prediction.h header file.

Fixes: 50705e8e3cdd ("eal: add assert macro for debug")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_eal/common/include/rte_debug.h | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Bruce Richardson May 5, 2016, 12:59 p.m. UTC | #1
On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote:
> The header file rte_debug.h makes use of the "unlikely" macro which
> means it should include the rte_branch_prediction.h header file.
> 
> Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/librte_eal/common/include/rte_debug.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h
> index 9260eda..cab6fb4 100644
> --- a/lib/librte_eal/common/include/rte_debug.h
> +++ b/lib/librte_eal/common/include/rte_debug.h
> @@ -44,6 +44,7 @@
>   */
>  
>  #include "rte_log.h"
> +#include "rte_branch_prediction.h"
>  
>  #ifdef __cplusplus
>  extern "C" {

Ping on this patch - any comments or concerns?
It's a fairly trivial fix that prevents issues with testing some other patches
on the mainline.

Regards,
/Bruce
  
Ferruh Yigit May 5, 2016, 4:07 p.m. UTC | #2
On 5/5/2016 1:59 PM, Bruce Richardson wrote:
> On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote:
>> The header file rte_debug.h makes use of the "unlikely" macro which
>> means it should include the rte_branch_prediction.h header file.
>>
>> Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>>  lib/librte_eal/common/include/rte_debug.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h
>> index 9260eda..cab6fb4 100644
>> --- a/lib/librte_eal/common/include/rte_debug.h
>> +++ b/lib/librte_eal/common/include/rte_debug.h
>> @@ -44,6 +44,7 @@
>>   */
>>  
>>  #include "rte_log.h"
>> +#include "rte_branch_prediction.h"
>>  
>>  #ifdef __cplusplus
>>  extern "C" {
> 
> Ping on this patch - any comments or concerns?
> It's a fairly trivial fix that prevents issues with testing some other patches
> on the mainline.
> 

Tested on top of David Marchand's 12123-12139 patchset.

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Thomas Monjalon May 5, 2016, 8:49 p.m. UTC | #3
2016-05-05 17:07, Ferruh Yigit:
> On 5/5/2016 1:59 PM, Bruce Richardson wrote:
> > On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote:
> >> The header file rte_debug.h makes use of the "unlikely" macro which
> >> means it should include the rte_branch_prediction.h header file.
> >>
> >> Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
> >>
> >> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > Ping on this patch - any comments or concerns?
> > It's a fairly trivial fix that prevents issues with testing some other patches
> > on the mainline.
> > 
> 
> Tested on top of David Marchand's 12123-12139 patchset.
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
Sorry for the delay, I was gardening today :)
  

Patch

diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h
index 9260eda..cab6fb4 100644
--- a/lib/librte_eal/common/include/rte_debug.h
+++ b/lib/librte_eal/common/include/rte_debug.h
@@ -44,6 +44,7 @@ 
  */
 
 #include "rte_log.h"
+#include "rte_branch_prediction.h"
 
 #ifdef __cplusplus
 extern "C" {