[dpdk-dev] remove poisoned flags

Message ID 1461097157-28925-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Thomas Monjalon April 19, 2016, 8:19 p.m. UTC
  Some flags were poisoned after having been removed from EAL and mbuf
in releases 1.8 (b10eef348d, 62814bc2e9) and 2.0 (4769bc5a27cc).
After several releases, they have probably disappeared from the applications.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 lib/librte_eal/common/include/rte_pci.h | 2 --
 lib/librte_mbuf/rte_mbuf.h              | 4 ----
 2 files changed, 6 deletions(-)
  

Comments

David Marchand April 20, 2016, 8:59 a.m. UTC | #1
On Tue, Apr 19, 2016 at 10:19 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> Some flags were poisoned after having been removed from EAL and mbuf
> in releases 1.8 (b10eef348d, 62814bc2e9) and 2.0 (4769bc5a27cc).
> After several releases, they have probably disappeared from the applications.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: David Marchand <david.marchand@6wind.com>
  
Thomas Monjalon April 22, 2016, 1:56 p.m. UTC | #2
2016-04-20 10:59, David Marchand:
> On Tue, Apr 19, 2016 at 10:19 PM, Thomas Monjalon
> <thomas.monjalon@6wind.com> wrote:
> > Some flags were poisoned after having been removed from EAL and mbuf
> > in releases 1.8 (b10eef348d, 62814bc2e9) and 2.0 (4769bc5a27cc).
> > After several releases, they have probably disappeared from the applications.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Acked-by: David Marchand <david.marchand@6wind.com>

Applied
  

Patch

diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
index 9f2301d..8fa2712 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/librte_eal/common/include/rte_pci.h
@@ -213,8 +213,6 @@  struct rte_pci_driver {
 
 /** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */
 #define RTE_PCI_DRV_NEED_MAPPING 0x0001
-/** Device driver must be registered several times until failure - deprecated */
-#pragma GCC poison RTE_PCI_DRV_MULTIPLE
 /** Device needs to be unbound even if no module is provided */
 #define RTE_PCI_DRV_FORCE_UNBIND 0x0004
 /** Device driver supports link state interrupt */
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 75a227d..451921f 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -65,10 +65,6 @@ 
 extern "C" {
 #endif
 
-/* deprecated options */
-#pragma GCC poison RTE_MBUF_SCATTER_GATHER
-#pragma GCC poison RTE_MBUF_REFCNT
-
 /*
  * Packet Offload Features Flags. It also carry packet type information.
  * Critical resources. Both rx/tx shared these bits. Be cautious on any change