diff mbox

[dpdk-dev] cfgfile: fix uninitialized scalar variable

Message ID 1460549702-16733-1-git-send-email-michalx.kobylinski@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Michal Kobylinski April 13, 2016, 12:15 p.m. UTC 
  CID 13323:
Uninitialized scalar variable. Using uninitialized value
cfg->num_sections when calling rte_cfgfile_close.

Fixes: eaafbad419bf ("cfgfile: library to interpret config files")

Signed-off-by: Michal Kobylinski <michalx.kobylinski@intel.com>
---
 lib/librte_cfgfile/rte_cfgfile.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Cristian Dumitrescu April 28, 2016, 10:48 a.m. UTC | #1 
> -----Original Message-----
> From: Kobylinski, MichalX
> Sent: Wednesday, April 13, 2016 1:15 PM
> To: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Kobylinski, MichalX <michalx.kobylinski@intel.com>
> Subject: [PATCH] cfgfile: fix uninitialized scalar variable
> 
> CID 13323:
> Uninitialized scalar variable. Using uninitialized value
> cfg->num_sections when calling rte_cfgfile_close.
> 
> Fixes: eaafbad419bf ("cfgfile: library to interpret config files")
> 
> Signed-off-by: Michal Kobylinski <michalx.kobylinski@intel.com>
> ---
>  lib/librte_cfgfile/rte_cfgfile.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
> index 75625a2..d72052a 100644
> --- a/lib/librte_cfgfile/rte_cfgfile.c
> +++ b/lib/librte_cfgfile/rte_cfgfile.c
> @@ -232,6 +232,7 @@ rte_cfgfile_load(const char *filename, int flags)
>  	return cfg;
> 
>  error1:
> +	cfg->num_sections = curr_section + 1;
>  	rte_cfgfile_close(cfg);
>  error2:
>  	fclose(f);
> --
> 1.9.1

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Thomas Monjalon May 2, 2016, 1 p.m. UTC | #2 
> > CID 13323:
> > Uninitialized scalar variable. Using uninitialized value
> > cfg->num_sections when calling rte_cfgfile_close.
> > 
> > Fixes: eaafbad419bf ("cfgfile: library to interpret config files")
> > 
> > Signed-off-by: Michal Kobylinski <michalx.kobylinski@intel.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index 75625a2..d72052a 100644
--- a/lib/librte_cfgfile/rte_cfgfile.c
+++ b/lib/librte_cfgfile/rte_cfgfile.c
@@ -232,6 +232,7 @@  rte_cfgfile_load(const char *filename, int flags)
 	return cfg;
 
 error1:
+	cfg->num_sections = curr_section + 1;
 	rte_cfgfile_close(cfg);
 error2:
 	fclose(f);