diff mbox

[dpdk-dev,v1] drivers/net/i40e: fix incorrect register dump offset

Message ID 1460540685-6167-1-git-send-email-remy.horton@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Remy Horton April 13, 2016, 9:44 a.m. UTC 
  The position of register values within i40e register dumps is
supposed to reflect the register addresses. These were not being
correctly calculated. 

Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping")

Signed-off-by: Remy Horton <remy.horton@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jingjing Wu April 14, 2016, 3:08 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> Sent: Wednesday, April 13, 2016 5:45 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump
> offset
> 
> The position of register values within i40e register dumps is supposed to
> reflect the register addresses. These were not being correctly calculated.
> 
> Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping")
> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Thanks
Jingjing
Bruce Richardson April 20, 2016, 2:44 p.m. UTC | #2 
On Thu, Apr 14, 2016 at 03:08:07AM +0000, Wu, Jingjing wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> > Sent: Wednesday, April 13, 2016 5:45 PM
> > To: Zhang, Helin
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump
> > offset
> > 
> > The position of register values within i40e register dumps is supposed to
> > reflect the register addresses. These were not being correctly calculated.
> > 
> > Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping")
> > 
> > Signed-off-by: Remy Horton <remy.horton@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>
Applied to dpdk-next-net/rel_16_07

Thanks,
/Bruce
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index bc28d3c..fc3a1d0 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -9031,6 +9031,7 @@  static int i40e_get_regs(struct rte_eth_dev *dev,
 					arr_idx2++) {
 				reg_offset = arr_idx * reg_info->stride1 +
 					arr_idx2 * reg_info->stride2;
+				reg_offset += reg_info->base_addr;
 				ptr_data[reg_offset >> 2] =
 					i40e_read_rx_ctl(hw, reg_offset);
 			}
@@ -9046,6 +9047,7 @@  static int i40e_get_regs(struct rte_eth_dev *dev,
 					arr_idx2++) {
 				reg_offset = arr_idx * reg_info->stride1 +
 					arr_idx2 * reg_info->stride2;
+				reg_offset += reg_info->base_addr;
 				ptr_data[reg_offset >> 2] =
 					I40E_READ_REG(hw, reg_offset);
 			}