diff mbox

[dpdk-dev] cryptodev: Remove EXPERIMENTAL label

Message ID 1459940708-8032-1-git-send-email-fiona.trahe@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Fiona Trahe April 6, 2016, 11:05 a.m. UTC 
  The cryptodev API was introduced in the DPDK 2.2 release.
Since then it has
 - been reviewed and iterated for the DPDK 16.04 release
 - had extensive use by the l2fwd-crypto app,
			the ipsec-secgw example app,
			the test app.
We believe it is now stable and the EXPERIMENTAL label should be removed.

v2:
- remove extra empty line

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 MAINTAINERS                          | 2 +-
 config/common_base                   | 1 -
 lib/librte_cryptodev/rte_cryptodev.h | 3 ---
 3 files changed, 1 insertion(+), 5 deletions(-)

Comments

Thomas Monjalon April 6, 2016, 4:37 p.m. UTC | #1 
2016-04-06 12:05, Fiona Trahe:
> The cryptodev API was introduced in the DPDK 2.2 release.
> Since then it has
>  - been reviewed and iterated for the DPDK 16.04 release
>  - had extensive use by the l2fwd-crypto app,
> 			the ipsec-secgw example app,
> 			the test app.
> We believe it is now stable and the EXPERIMENTAL label should be removed.

I thought it was a good idea to use a dpdk_ prefix in this new "stable" lib,
but it appears that almost everybody is against having a mix of prefixes.

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

> v2:

The v2 is missing in the title (option -v2 in git).
Fiona Trahe April 6, 2016, 4:46 p.m. UTC | #2 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, April 06, 2016 5:37 PM
> To: Trahe, Fiona
> Cc: dev@dpdk.org; Doherty, Declan
> Subject: Re: [dpdk-dev] [PATCH] cryptodev: Remove EXPERIMENTAL label
> 
> 2016-04-06 12:05, Fiona Trahe:
> > The cryptodev API was introduced in the DPDK 2.2 release.
> > Since then it has
> >  - been reviewed and iterated for the DPDK 16.04 release
> >  - had extensive use by the l2fwd-crypto app,
> > 			the ipsec-secgw example app,
> > 			the test app.
> > We believe it is now stable and the EXPERIMENTAL label should be removed.
> 
> I thought it was a good idea to use a dpdk_ prefix in this new "stable" lib, but it
> appears that almost everybody is against having a mix of prefixes.
> 
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> > v2:
> 
> The v2 is missing in the title (option -v2 in git).
Sorry :(
Do  you want me to resend with updated subject?
Thomas Monjalon April 6, 2016, 4:49 p.m. UTC | #3 
2016-04-06 16:46, Trahe, Fiona:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > v2:
> > 
> > The v2 is missing in the title (option -v2 in git).
> Sorry :(
> Do  you want me to resend with updated subject?

No, it was just for information for next times.
Thomas Monjalon April 6, 2016, 5:07 p.m. UTC | #4 
> > The cryptodev API was introduced in the DPDK 2.2 release.
> > Since then it has
> >  - been reviewed and iterated for the DPDK 16.04 release
> >  - had extensive use by the l2fwd-crypto app,
> > 			the ipsec-secgw example app,
> > 			the test app.
> > We believe it is now stable and the EXPERIMENTAL label should be removed.
> 
> I thought it was a good idea to use a dpdk_ prefix in this new "stable" lib,
> but it appears that almost everybody is against having a mix of prefixes.
> 
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 85d72ca..a7570cd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -231,7 +231,7 @@  M: Thomas Monjalon <thomas.monjalon@6wind.com>
 F: lib/librte_ether/
 F: scripts/test-null.sh
 
-Crypto API - EXPERIMENTAL
+Crypto API
 M: Declan Doherty <declan.doherty@intel.com>
 F: lib/librte_cryptodev/
 F: app/test/test_cryptodev*
diff --git a/config/common_base b/config/common_base
index abd6a64..0124e86 100644
--- a/config/common_base
+++ b/config/common_base
@@ -327,7 +327,6 @@  CONFIG_RTE_PMD_PACKET_PREFETCH=y
 
 #
 # Compile generic crypto device library
-# EXPERIMENTAL: API may change without prior notice
 #
 CONFIG_RTE_LIBRTE_CRYPTODEV=y
 CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 568ffbb..d47f1e8 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -39,9 +39,6 @@ 
  *
  * Defines RTE Crypto Device APIs for the provisioning of cipher and
  * authentication operations.
- *
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  */
 
 #ifdef __cplusplus