diff mbox

[dpdk-dev] autotests: fix eal flags test

Message ID 1459786795-28291-1-git-send-email-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Olivier Matz April 4, 2016, 4:19 p.m. UTC 
  Since commit a88ba49e51, values larger than 4 are allowed,
the autotests need to be updated accordingly.

Fixes: a88ba49e51 ("config: fix CPU and memory parameters on IBM POWER8")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 app/test/test_eal_flags.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

De Lara Guarch, Pablo April 5, 2016, 9:52 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz
> Sent: Monday, April 04, 2016 5:20 PM
> To: dev@dpdk.org
> Cc: chaozhu@linux.vnet.ibm.com
> Subject: [dpdk-dev] [PATCH] autotests: fix eal flags test
> 
> Since commit a88ba49e51, values larger than 4 are allowed,
> the autotests need to be updated accordingly.
> 
> Fixes: a88ba49e51 ("config: fix CPU and memory parameters on IBM
> POWER8")
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com
Thomas Monjalon April 6, 2016, 10:02 a.m. UTC | #2 
> > Since commit a88ba49e51, values larger than 4 are allowed,
> > the autotests need to be updated accordingly.
> > 
> > Fixes: a88ba49e51 ("config: fix CPU and memory parameters on IBM
> > POWER8")
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com

Applied, thanks
diff mbox

Patch

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index d9c0d93..93ae6e7 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -698,8 +698,8 @@  test_invalid_n_flag(void)
 	const char *argv1[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n"};
 	/* bad numeric value */
 	const char *argv2[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n", "e" };
-	/* out-of-range value */
-	const char *argv3[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n", "9" };
+	/* zero is invalid */
+	const char *argv3[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n", "0" };
 	/* sanity test - check with good value */
 	const char *argv4[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n", "2" };
 	/* sanity test - check with no -n flag */